doc: remove note about macOS self-signing #32003

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_code_signing_note changing 1 files +0 −7
  1. fanquake commented at 5:21 pm on March 5, 2025: member
    Followup to #31407.
  2. DrahtBot commented at 5:22 pm on March 5, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32003.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK Sjors, achow101
    Concept ACK luke-jr

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Mar 5, 2025
  4. glozow added this to the milestone 29.0 on Mar 5, 2025
  5. doc: remove note about macOS self-signing
    Followup to #31407.
    c873ab6f23
  6. fanquake force-pushed on Mar 5, 2025
  7. Sjors commented at 6:03 pm on March 5, 2025: member

    ACK c873ab6f23e027af1c5837256ce3c9eccaf409cb

    The binaries we ship are signed and notarized now. If the user compiles from source, self-signing happens automatically.

    If the user (cross) compiles from source to put it on a different computer, they’ll still need to do this on the target machine. But this is probably not the right place to describe cross-compilation steps.

    Removing these instructions here is also safer: if someone messes with the binaries, the user will get an error from macOS. They might then follow the instructions here and shoot themselves in the foot by self signing a malicious binary. (a less lazy attacker would mess with the instruction of course)

  8. achow101 commented at 6:39 pm on March 5, 2025: member
    It may still be useful to mention xattr -d com.apple.quarantine for the binaries since it’s necessary to do that to run them from finder. Although I’m not sure it even makes sense to try to run our binaries from finder. Even with bitcoin-qt, it still opens up a terminal that has to be open while the GUI is running.
  9. luke-jr approved
  10. luke-jr commented at 11:51 pm on March 5, 2025: member
    ACK, confirmed this is no longer necessary on macOS
  11. fanquake marked this as ready for review on Mar 6, 2025
  12. achow101 assigned achow101 on Mar 6, 2025
  13. achow101 commented at 5:59 pm on March 6, 2025: member
    ACK c873ab6f23e027af1c5837256ce3c9eccaf409cb
  14. DrahtBot requested review from luke-jr on Mar 6, 2025
  15. achow101 merged this on Mar 6, 2025
  16. achow101 closed this on Mar 6, 2025

  17. fanquake deleted the branch on Mar 6, 2025


fanquake DrahtBot Sjors achow101 luke-jr


luke-jr

Labels
Docs

Milestone
29.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-03 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me