doc: remove note about macOS self-signing #32003

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_code_signing_note changing 1 files +0 −7

fanquake commented at 5:21 PM on March 5, 2025: member

Followup to #31407.
DrahtBot commented at 5:22 PM on March 5, 2025: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32003.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK Sjors, achow101

Concept ACK luke-jr

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Docs on Mar 5, 2025
glozow added this to the milestone 29.0 on Mar 5, 2025
doc: remove note about macOS self-signing
Followup to #31407.
c873ab6f23
fanquake force-pushed on Mar 5, 2025
Sjors commented at 6:03 PM on March 5, 2025: member

ACK c873ab6f23e027af1c5837256ce3c9eccaf409cb

The binaries we ship are signed and notarized now. If the user compiles from source, self-signing happens automatically.

If the user (cross) compiles from source to put it on a different computer, they'll still need to do this on the target machine. But this is probably not the right place to describe cross-compilation steps.

Removing these instructions here is also safer: if someone messes with the binaries, the user will get an error from macOS. They might then follow the instructions here and shoot themselves in the foot by self signing a malicious binary. (a less lazy attacker would mess with the instruction of course)
achow101 commented at 6:39 PM on March 5, 2025: member

It may still be useful to mention xattr -d com.apple.quarantine for the binaries since it's necessary to do that to run them from finder. Although I'm not sure it even makes sense to try to run our binaries from finder. Even with bitcoin-qt, it still opens up a terminal that has to be open while the GUI is running.
luke-jr approved
luke-jr commented at 11:51 PM on March 5, 2025: member

ACK, confirmed this is no longer necessary on macOS
fanquake marked this as ready for review on Mar 6, 2025
achow101 assigned achow101 on Mar 6, 2025
achow101 commented at 5:59 PM on March 6, 2025: member

ACK c873ab6f23e027af1c5837256ce3c9eccaf409cb
DrahtBot requested review from luke-jr on Mar 6, 2025
achow101 merged this on Mar 6, 2025
achow101 closed this on Mar 6, 2025
fanquake deleted the branch on Mar 6, 2025
sedited referenced this in commit 2cab7a09ea on Mar 16, 2025
stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
stickies-v referenced this in commit cc83553352 on Mar 17, 2025
stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
fanquake referenced this in commit fcbccf3ba0 on May 19, 2025
fanquake referenced this in commit 07a6cd75d2 on May 30, 2025
fanquake referenced this in commit 52f09633d0 on Jun 2, 2025
fanquake referenced this in commit 7f1da76269 on Jun 5, 2025
bug-castercv502 referenced this in commit a6aeab1eeb on Sep 28, 2025
ivanlele referenced this in commit ea9aee434a on Apr 16, 2026
morozow referenced this in commit d478045f39 on May 8, 2026
morozow referenced this in commit 1ad944c253 on May 8, 2026
Kino1994 referenced this in commit ea3f7b6055 on Jun 28, 2026
BigcoinBGC referenced this in commit 62d4cf5afa on Jun 30, 2026
bitcoin locked this on Jul 30, 2026