This PR is a follow-up to #31844 and extends the changes from fb0546b1c5ebb858605bef4c9fa001782e0ab213 to all fuzz builds in the CI.
Fixes #32001.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32014.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | dergoegge |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
15@@ -16,7 +16,7 @@ export CONTAINER_NAME="ci_native_msan"
16 export PACKAGES="ninja-build"
17 # BDB generates false-positives and will be removed in future
18 export DEP_OPTS="DEBUG=1 NO_BDB=1 NO_QT=1 CC=clang CXX=clang++ CFLAGS='${MSAN_FLAGS}' CXXFLAGS='${MSAN_AND_LIBCXX_FLAGS}'"
19-export GOAL="install"
20+export GOAL="all"
Why does this need to change? The regular msan job is not broken afaik.
Right. It wasn’t my intention. Reverted.
Is it possible to open a PR to the QA repo that demonstrates that this actually fixes the problem?
Where in the CMake code is $GOAL
processed?
I see this in the CI code:
0bash -c "cmake --build . $MAKEJOBS --target all $GOAL"
But after that I lost track.
Where in the CMake code is
$GOAL
processed?I see this in the CI code:
0bash -c "cmake --build . $MAKEJOBS --target all $GOAL"
But after that I lost track.
This is the only place.
Is it possible to open a PR to the QA repo that demonstrates that this actually fixes the problem?
Trying it here: https://github.com/bitcoin-core/qa-assets/pull/219
utACK a3c3f37e71efc1ad13fcad49b1ac651e5843b26b
This fixes the build issue seen earlier on https://github.com/bitcoin-core/qa-assets/pull/219