ci: Do not try to install for fuzz builds #32014

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250307-fuzz-install changing 2 files +2 −2
  1. hebasto commented at 8:06 am on March 7, 2025: member

    This PR is a follow-up to #31844 and extends the changes from fb0546b1c5ebb858605bef4c9fa001782e0ab213 to all fuzz builds in the CI.

    Fixes #32001.

  2. hebasto added the label Tests on Mar 7, 2025
  3. DrahtBot commented at 8:06 am on March 7, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32014.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #28710 (Remove the legacy wallet and BDB dependency by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. hebasto added this to the milestone 29.0 on Mar 7, 2025
  5. in ci/test/00_setup_env_native_msan.sh:19 in bddec4fd3d outdated
    15@@ -16,7 +16,7 @@ export CONTAINER_NAME="ci_native_msan"
    16 export PACKAGES="ninja-build"
    17 # BDB generates false-positives and will be removed in future
    18 export DEP_OPTS="DEBUG=1 NO_BDB=1 NO_QT=1 CC=clang CXX=clang++ CFLAGS='${MSAN_FLAGS}' CXXFLAGS='${MSAN_AND_LIBCXX_FLAGS}'"
    19-export GOAL="install"
    20+export GOAL="all"
    


    dergoegge commented at 9:21 am on March 7, 2025:
    Why does this need to change? The regular msan job is not broken afaik.

    Sjors commented at 10:05 am on March 7, 2025:
    It does seem more correct. Perhaps in the future we can even warn users when they’re about to install a debug, sanitizer or otherwise potentially very slow and crash-prone binary.

    hebasto commented at 11:10 am on March 7, 2025:

    Why does this need to change? The regular msan job is not broken afaik.

    Right. It wasn’t my intention. Reverted.

  6. Sjors commented at 10:12 am on March 7, 2025: member

    Is it possible to open a PR to the QA repo that demonstrates that this actually fixes the problem?

    Where in the CMake code is $GOAL processed?

    I see this in the CI code:

    0bash -c "cmake --build . $MAKEJOBS --target all $GOAL" 
    

    But after that I lost track.

  7. ci: Do not try to install for fuzz builds a3c3f37e71
  8. hebasto force-pushed on Mar 7, 2025
  9. hebasto commented at 11:12 am on March 7, 2025: member

    Where in the CMake code is $GOAL processed?

    I see this in the CI code:

    0bash -c "cmake --build . $MAKEJOBS --target all $GOAL" 
    

    But after that I lost track.

    This is the only place.

  10. marcofleon commented at 11:12 am on March 7, 2025: contributor

    Is it possible to open a PR to the QA repo that demonstrates that this actually fixes the problem?

    Trying it here: https://github.com/bitcoin-core/qa-assets/pull/219

  11. dergoegge approved
  12. dergoegge commented at 1:32 pm on March 7, 2025: member

    utACK a3c3f37e71efc1ad13fcad49b1ac651e5843b26b

    This fixes the build issue seen earlier on https://github.com/bitcoin-core/qa-assets/pull/219

  13. fanquake merged this on Mar 7, 2025
  14. fanquake closed this on Mar 7, 2025

  15. hebasto deleted the branch on Mar 7, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-29 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me