ci: Do not try to install for fuzz builds #32014

1. 
   hebasto commented at 8:06 AM on March 7, 2025: member

   This PR is a follow-up to #31844 and extends the changes from fb0546b1c5ebb858605bef4c9fa001782e0ab213 to all fuzz builds in the CI.

   Fixes #32001.

2. hebasto added the label Tests on Mar 7, 2025
3. 
   DrahtBot commented at 8:06 AM on March 7, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32014.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #28710 (Remove the legacy wallet and BDB dependency by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. hebasto added this to the milestone 29.0 on Mar 7, 2025
5. in ci/test/00_setup_env_native_msan.sh:19 in bddec4fd3d outdated

     15 | @@ -16,7 +16,7 @@ export CONTAINER_NAME="ci_native_msan"
     16 |  export PACKAGES="ninja-build"
     17 |  # BDB generates false-positives and will be removed in future
     18 |  export DEP_OPTS="DEBUG=1 NO_BDB=1 NO_QT=1 CC=clang CXX=clang++ CFLAGS='${MSAN_FLAGS}' CXXFLAGS='${MSAN_AND_LIBCXX_FLAGS}'"
     19 | -export GOAL="install"
     20 | +export GOAL="all"
   

   ---

   ---

   

   dergoegge commented at 9:21 AM on March 7, 2025:

   Why does this need to change? The regular msan job is not broken afaik.

   ---

   

   Sjors commented at 10:05 AM on March 7, 2025:

   It does seem more correct. Perhaps in the future we can even warn users when they're about to install a debug, sanitizer or otherwise potentially very slow and crash-prone binary.

   ---

   

   hebasto commented at 11:10 AM on March 7, 2025:

   Why does this need to change? The regular msan job is not broken afaik.

   Right. It wasn't my intention. Reverted.

6. 
   Sjors commented at 10:12 AM on March 7, 2025: member

   Is it possible to open a PR to the QA repo that demonstrates that this actually fixes the problem?

   Where in the CMake code is $GOAL processed?

   I see this in the CI code:

   bash -c "cmake --build . $MAKEJOBS --target all $GOAL" 
   

   But after that I lost track.

7. ci: Do not try to install for fuzz builds a3c3f37e71
8. hebasto force-pushed on Mar 7, 2025
9. 
   hebasto commented at 11:12 AM on March 7, 2025: member

   Where in the CMake code is $GOAL processed?

   I see this in the CI code:

   bash -c "cmake --build . $MAKEJOBS --target all $GOAL" 
   

   But after that I lost track.

   This is the only place.

10. 
    marcofleon commented at 11:12 AM on March 7, 2025: contributor

    Is it possible to open a PR to the QA repo that demonstrates that this actually fixes the problem?

    Trying it here: https://github.com/bitcoin-core/qa-assets/pull/219

11. dergoegge approved
12. 
    dergoegge commented at 1:32 PM on March 7, 2025: member

    utACK a3c3f37e71efc1ad13fcad49b1ac651e5843b26b

    This fixes the build issue seen earlier on https://github.com/bitcoin-core/qa-assets/pull/219

13. fanquake merged this on Mar 7, 2025
14. fanquake closed this on Mar 7, 2025

    ---

15. hebasto deleted the branch on Mar 7, 2025

Contributors

hebastoDrahtBotdergoeggeSjorsmarcofleon

Milestone
29.0