build: Remove manpages when making MacOS app #32064

1. 
   achow101 commented at 1:09 am on March 14, 2025: member

   When creating the MacOS app, the only file that should be in Bitcoin-Qt.app/Contents/MacOS is Bitcoin-Qt. Since #31844, there was also a share/ containing the manpage for bitcoin-qt. This manpage is not useful to app users, and it is also causing code signing issues. Thus the directory should be removed when making the app.

   Fixes #32052 (comment)

2. build: Remove manpages when making MacOS app 80b5e7f2cb
3. achow101 added the label Needs backport (29.x) on Mar 14, 2025
4. achow101 added this to the milestone 29.0 on Mar 14, 2025
5. 
   DrahtBot commented at 1:09 am on March 14, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32064.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. fanquake approved
7. 
   fanquake commented at 3:06 am on March 14, 2025: member

   ACK 80b5e7f2cb7fbfbd724e1f52b00c0e72b79a200b
8. fanquake merged this on Mar 14, 2025
9. fanquake closed this on Mar 14, 2025

   ---

10. 
    pinheadmz commented at 1:38 pm on March 14, 2025: member

    post-merge tested ACK

    successful guix build, code sign, and signature attach from current master, ran signed Qt and bitcoind on arm64/macos. Didn’t test x86: https://github.com/pinheadmz/bitcoin-detached-sigs/tree/master-698f86964c

11. 
    hebasto commented at 2:24 pm on March 14, 2025: member

    Post-merge ACK 80b5e7f2cb7fbfbd724e1f52b00c0e72b79a200b.
12. 
    Sjors commented at 4:19 pm on March 14, 2025: member

    Having the man files in the .tar.gz release, where bitcoind and bitcoin-cli live, should be enough.
13. TheCharlatan referenced this in commit 2cab7a09ea on Mar 16, 2025
14. glozow referenced this in commit 7ff0b02161 on Mar 17, 2025
15. 
    glozow commented at 2:12 am on March 17, 2025: member

    Backported in #32062
16. glozow removed the label Needs backport (29.x) on Mar 17, 2025
17. DrahtBot added the label Build system on Mar 17, 2025

Contributors
achow101 DrahtBot fanquake pinheadmz hebasto Sjors glozow

Labels
Build system

Milestone
29.0