build: Remove manpages when making MacOS app #32064

1. 
   achow101 commented at 1:09 AM on March 14, 2025: member

   When creating the MacOS app, the only file that should be in Bitcoin-Qt.app/Contents/MacOS is Bitcoin-Qt. Since #31844, there was also a share/ containing the manpage for bitcoin-qt. This manpage is not useful to app users, and it is also causing code signing issues. Thus the directory should be removed when making the app.

   Fixes #32052 (comment)

2. build: Remove manpages when making MacOS app 80b5e7f2cb
3. achow101 added the label Needs backport (29.x) on Mar 14, 2025
4. achow101 added this to the milestone 29.0 on Mar 14, 2025
5. 
   DrahtBot commented at 1:09 AM on March 14, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32064.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. fanquake approved
7. 
   fanquake commented at 3:06 AM on March 14, 2025: member

   ACK 80b5e7f2cb7fbfbd724e1f52b00c0e72b79a200b

8. fanquake merged this on Mar 14, 2025
9. fanquake closed this on Mar 14, 2025

   ---

10. 
    pinheadmz commented at 1:38 PM on March 14, 2025: member

    post-merge tested ACK

    successful guix build, code sign, and signature attach from current master, ran signed Qt and bitcoind on arm64/macos. Didn't test x86: https://github.com/pinheadmz/bitcoin-detached-sigs/tree/master-698f86964c

11. 
    hebasto commented at 2:24 PM on March 14, 2025: member

    Post-merge ACK 80b5e7f2cb7fbfbd724e1f52b00c0e72b79a200b.

12. 
    Sjors commented at 4:19 PM on March 14, 2025: member

    Having the man files in the .tar.gz release, where bitcoind and bitcoin-cli live, should be enough.

13. sedited referenced this in commit 2cab7a09ea on Mar 16, 2025
14. glozow referenced this in commit 7ff0b02161 on Mar 17, 2025
15. 
    glozow commented at 2:12 AM on March 17, 2025: member

    Backported in #32062

16. glozow removed the label Needs backport (29.x) on Mar 17, 2025
17. DrahtBot added the label Build system on Mar 17, 2025
18. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
19. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
20. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
21. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
22. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
23. fanquake referenced this in commit d6db87165c on Mar 18, 2025
24. bug-castercv502 referenced this in commit a6aeab1eeb on Sep 28, 2025
25. morozow referenced this in commit 5c99872984 on May 8, 2026
26. morozow referenced this in commit deb171a705 on May 8, 2026
27. Kino1994 referenced this in commit 8bd3f75f8d on Jun 28, 2026
28. BigcoinBGC referenced this in commit 0b2fb1f5d4 on Jun 30, 2026
29. bitcoin locked this on Jul 30, 2026

Milestone
29.0