doc: Update comments for AreInputsStandard to match code #32129

pull ajtowns wants to merge 1 commits into bitcoin:master from ajtowns:202503-areinputstd-comment changing 1 files +11 −13
  1. ajtowns commented at 9:09 am on March 24, 2025: contributor
    The comment about extra data stuffed in scriptSigs was introduced in #4365 which introduced ScriptSigArgsExpected(), and became incorrect after #7387 / #7453 (checks are now performed by SCRIPT_VERIFY_CLEANSTACK during script validation and IsPushOnly() in IsStandardTx()). Drops the details on what a p2sh with many checksigs would look like, which was already done in #4365, but only for main.cpp not the duplicated comment in main.h, which was merged into policy/policy.cpp in #6335 and later moved to the right place in #10682.
  2. DrahtBot commented at 9:09 am on March 24, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32129.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK instagibbs, darosior

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Mar 24, 2025
  4. in src/policy/policy.cpp:175 in 0f6e02dc7e outdated
    183- * which will get accepted into blocks. The redemption
    184- * script can be anything; an attacker could use a very
    185- * expensive-to-check-upon-redemption script like:
    186- *   DUP CHECKSIG DROP ... repeated 100 times... OP_1
    187+ * This does two things:
    188+ *  * Prevents mempool acceptance of spends of future
    


    instagibbs commented at 1:19 pm on March 24, 2025:
    It’s still filtering other types of non-standard scripts, which also protects against the same issue of lots of operations (in addition to offering upgrade hooks)

    ajtowns commented at 8:59 am on March 26, 2025:
    Added some text.
  5. darosior commented at 1:54 pm on March 24, 2025: member
    Concept ACK
  6. doc: Update comments for AreInputsStandard to match code 52ede28a8a
  7. ajtowns force-pushed on Mar 26, 2025
  8. instagibbs commented at 1:36 pm on March 26, 2025: member
    ACK 52ede28a8adb2c2d44d7f800bbfbef8aed86070e
  9. DrahtBot requested review from darosior on Mar 26, 2025
  10. darosior approved
  11. darosior commented at 1:40 pm on March 26, 2025: member
    ACK 52ede28a8adb2c2d44d7f800bbfbef8aed86070e
  12. fanquake merged this on Mar 27, 2025
  13. fanquake closed this on Mar 27, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-28 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me