Mistake in feature_pruning.py functional test? #32249

1. 
   sipa commented at 12:03 pm on April 11, 2025: member

   Reported on IRC yesterday:

   017:24:04 < PiRK_> Good evening. I was looking through a functional test and i'm wondering if this isn't a typo: 
   1                  https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_pruning.py#L44
   217:24:04 < PiRK_> "nTimes" vs `nTime`
   317:27:08 < sipa> PiRK_: looks like it
   

   The code is definitely not doing what the comment says, as it’s always resetting mine_large_blocks.nTime to 0, rather than only on the first run. However, if I fix it, the test does not pass anymore.

   Filing this as an issue so someone who is more familiar with the test or feels like digging in can have a look.

2. sipa added the label Tests on Apr 11, 2025
3. 
   sipa commented at 3:58 pm on April 15, 2025: member

   For anyone wanting to fix this, note that feature_pruning.py is not run by default. Please verify locally that your changes don’t break the test.

Contributors
sipa

Labels
Tests