This includes a cmake documentation change suggested #31741 (review) and another change to mention the option in markdown documentation
doc: Document WITH_EXTERNAL_LIBMULTIPROCESS build option better #32271
pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/extdoc changing 2 files +5 −1-
ryanofsky commented at 8:35 PM on April 14, 2025: contributor
-
9ccee9cd02
doc: Document WITH_EXTERNAL_LIBMULTIPROCESS build option better
This includes a cmake documentation change suggested https://github.com/bitcoin/bitcoin/pull/31741#discussion_r2039716492 and another change to mention the option in markdown documentation Co-authored-by: Cory Fields <cory-nospam-@coryfields.com>
-
DrahtBot commented at 8:35 PM on April 14, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32271.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto, TheCharlatan If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #31802 (Add bitcoin-{node,gui} to release binaries for IPC by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Docs on Apr 14, 2025
- hebasto approved
-
hebasto commented at 8:43 PM on April 15, 2025: member
ACK 9ccee9cd022dcce72608831d4b1b93991345b306, changes look good.
- TheCharlatan approved
-
TheCharlatan commented at 12:36 PM on April 16, 2025: contributor
ACK 9ccee9cd022dcce72608831d4b1b93991345b306
-
- fanquake merged this on Apr 17, 2025
- fanquake closed this on Apr 17, 2025
