This reverts commit 27f11217ca63e0f8f78f14db139150052dcd9962.
The commit was nice and useful. However, CI doesn’t pass, see #32291. Temporarily revert it, so that it can be enabled again along with the issue fixed.
This reverts commit 27f11217ca63e0f8f78f14db139150052dcd9962.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32302.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | l0rinc |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
WalletMigration
benchmark by hebasto)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
ACK fadccd9e4ab29fa703dd5a6f42fae030176a86f3
Build passes now, we will have to rebase a few PRs after this so it makes sense to merge it ASAP.
Can we add a different change, to continue running all benchmarks (I guess just not Windows), so we aren’t back to the same state that allowed #32277 to happen?
Yes, happy to follow-up next week, as explained in #32288 (review)
May this be closed in favour of #32306?
No strong opinion, I think either is equally fine.
Closing this one for now, because it has less acks.