test: remove Boost SIGCHLD workaround. #32403

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:drop_boost_signal changing 1 files +0 −8
  1. fanquake commented at 10:03 am on May 2, 2025: member
  2. test: remove Boost SIGCHLD workaround.
    The related code was removed from Boost in
    https://github.com/boostorg/test/commit/2e3bd1025d417f661a7edbf7b7dbcb801118033d.
    3add6ab9ad
  3. DrahtBot commented at 10:03 am on May 2, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32403.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK laanwj, hebasto, mabu44, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #31860 (init: Take lock on blocks directory in BlockManager ctor by TheCharlatan)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label Tests on May 2, 2025
  5. laanwj approved
  6. laanwj commented at 10:56 am on May 2, 2025: member
    ACK 3add6ab9adcd722d57c6d488581358ae9b377f1a
  7. hebasto approved
  8. hebasto commented at 2:18 pm on May 2, 2025: member
    ACK 3add6ab9adcd722d57c6d488581358ae9b377f1a, I have reviewed the code and it looks OK.
  9. mabu44 commented at 5:34 pm on May 2, 2025: none

    ACK 3add6ab9adcd722d57c6d488581358ae9b377f1a

    Reviewed the changes and compiled the code, then run

    0./build_dev/bin/test_bitcoin --log_level=all --run_test=util_tests/test_LockDirectory
    

    The output of the test looks good to me.

  10. achow101 commented at 8:40 pm on May 2, 2025: member
    ACK 3add6ab9adcd722d57c6d488581358ae9b377f1a
  11. achow101 merged this on May 2, 2025
  12. achow101 closed this on May 2, 2025

  13. fanquake deleted the branch on May 5, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-05 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me