The related code was removed from Boost in https://github.com/boostorg/test/commit/2e3bd1025d417f661a7edbf7b7dbcb801118033d.
test: remove Boost SIGCHLD workaround. #32403
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:drop_boost_signal changing 1 files +0 −8-
fanquake commented at 10:03 AM on May 2, 2025: member
-
3add6ab9ad
test: remove Boost SIGCHLD workaround.
The related code was removed from Boost in https://github.com/boostorg/test/commit/2e3bd1025d417f661a7edbf7b7dbcb801118033d.
-
DrahtBot commented at 10:03 AM on May 2, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32403.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #31860 (init: Take lock on blocks directory in BlockManager ctor by TheCharlatan)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label Tests on May 2, 2025
- laanwj approved
-
laanwj commented at 10:56 AM on May 2, 2025: member
ACK 3add6ab9adcd722d57c6d488581358ae9b377f1a
- hebasto approved
-
hebasto commented at 2:18 PM on May 2, 2025: member
ACK 3add6ab9adcd722d57c6d488581358ae9b377f1a, I have reviewed the code and it looks OK.
-
mabu44 commented at 5:34 PM on May 2, 2025: none
ACK 3add6ab9adcd722d57c6d488581358ae9b377f1a
<details> <summary>Testing procedure</summary>
Reviewed the changes and compiled the code, then run
./build_dev/bin/test_bitcoin --log_level=all --run_test=util_tests/test_LockDirectoryThe output of the test looks good to me.
</details>
-
achow101 commented at 8:40 PM on May 2, 2025: member
ACK 3add6ab9adcd722d57c6d488581358ae9b377f1a
- achow101 merged this on May 2, 2025
- achow101 closed this on May 2, 2025
- fanquake deleted the branch on May 5, 2025
- stickies-v referenced this in commit 772a33e052 on May 23, 2025
- sedited referenced this in commit cb3cd9b8b9 on May 29, 2025
- yuvicc referenced this in commit 069643f094 on Jul 6, 2025
- bug-castercv502 referenced this in commit 2858098810 on Sep 28, 2025
- Kino1994 referenced this in commit ed5bf0e366 on Jun 28, 2026
- BigcoinBGC referenced this in commit adc318b0f2 on Jun 30, 2026
- bitcoin locked this on Jul 30, 2026
