crypto: disable ASan for sha256

fanquake commented at 10:54 am on May 7, 2025: member

This also fails to compile when optimisations are being used, see: #31913. So just disable ASan under any optimisation level.

Closes #31913.

crypto: disable ASan for sha256_sse4 with Clang

This can alsofail to compile when optimisations are being used, see:
https://github.com/bitcoin/bitcoin/issues/31913.
So disable just ASan for this function under any optimisation level.

4e8ab5e00f

DrahtBot commented at 10:54 am on May 7, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32437.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	laanwj, maflcko, davidgumberg
Concept ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Utils/log/libs on May 7, 2025

maflcko added the label DrahtBot Guix build requested on May 7, 2025

hebasto commented at 11:49 am on May 7, 2025: member

Concept ACK.

laanwj approved

laanwj commented at 11:55 am on May 7, 2025: member

Code review ACK 4e8ab5e00fa72016a7ec0e0505ca025d4e59e4d8 Have not tested.

DrahtBot requested review from hebasto on May 7, 2025

maflcko commented at 12:23 pm on May 7, 2025: member

lgtm ACK 4e8ab5e00fa72016a7ec0e0505ca025d4e59e4d8

I haven’t tested this, but the diff looks plausible

fanquake commented at 3:26 pm on May 7, 2025: member

Guix build:

 020608607794819e22c0bc02c920ba03a4edf98b902e278f1e2dcc9d92f2f485f  guix-build-4e8ab5e00fa7/output/aarch64-linux-gnu/SHA256SUMS.part
 1f3268558a957a2b55191b14bdb9f7c23d60dc72a84ecbfe6b56a280f8f09fd1f  guix-build-4e8ab5e00fa7/output/aarch64-linux-gnu/bitcoin-4e8ab5e00fa7-aarch64-linux-gnu-debug.tar.gz
 2791e1b3e81b358343dd5fafa53ab1d503e819d6935515277443dcfef4091c470  guix-build-4e8ab5e00fa7/output/aarch64-linux-gnu/bitcoin-4e8ab5e00fa7-aarch64-linux-gnu.tar.gz
 31b689d1c92f6026d995479b469bdb27445c4d24211172b4df6d2a0154e3ec59b  guix-build-4e8ab5e00fa7/output/arm-linux-gnueabihf/SHA256SUMS.part
 4e0b9909538378698752be25ce2e4985686e3af4bb063e6e74d650ffa6c3e9499  guix-build-4e8ab5e00fa7/output/arm-linux-gnueabihf/bitcoin-4e8ab5e00fa7-arm-linux-gnueabihf-debug.tar.gz
 510bde1be812db42797de38fc8bb7bbe2539fb8aa2ddf44aef3eca80fb62d60ce  guix-build-4e8ab5e00fa7/output/arm-linux-gnueabihf/bitcoin-4e8ab5e00fa7-arm-linux-gnueabihf.tar.gz
 63180414f79510552b09e16691783fd31d1026e4ec4483ee35c92cb8b0fa4ff8d  guix-build-4e8ab5e00fa7/output/arm64-apple-darwin/SHA256SUMS.part
 7244b0c23873f5c2870f18248b4bc776b03a02d85bba52ae3129cbd18925e5b8f  guix-build-4e8ab5e00fa7/output/arm64-apple-darwin/bitcoin-4e8ab5e00fa7-arm64-apple-darwin-codesigning.tar.gz
 87e2ef8fd9be1a86f19ee681d5be02f5d1c383e609f83aed09bf1badbf8cdafa4  guix-build-4e8ab5e00fa7/output/arm64-apple-darwin/bitcoin-4e8ab5e00fa7-arm64-apple-darwin-unsigned.tar.gz
 9d3849d36e7145d6bd6010c470bb0ea45541ffe9bed024d6af7a653bafde61abe  guix-build-4e8ab5e00fa7/output/arm64-apple-darwin/bitcoin-4e8ab5e00fa7-arm64-apple-darwin-unsigned.zip
10b09a548098729b646ccd1e5a3002876df0755da413d0b09c0a85d96fd89124e6  guix-build-4e8ab5e00fa7/output/dist-archive/bitcoin-4e8ab5e00fa7.tar.gz
11df546e3d6a4d0e5781e9850475021f6e000768ed8056052149a95159d560e0a3  guix-build-4e8ab5e00fa7/output/powerpc64-linux-gnu/SHA256SUMS.part
123f3c68023117391cb73569e250c236ba5173b56df44bfbf5fcc683c4c38ac886  guix-build-4e8ab5e00fa7/output/powerpc64-linux-gnu/bitcoin-4e8ab5e00fa7-powerpc64-linux-gnu-debug.tar.gz
134950dedd7b5d537d2e856e8ad3155edaabe28775acb7e5231b0115a4d10f8bbc  guix-build-4e8ab5e00fa7/output/powerpc64-linux-gnu/bitcoin-4e8ab5e00fa7-powerpc64-linux-gnu.tar.gz
14e7a06ec17074800ef71c8d8244bdb72c57e378c242731ed0bed3e10bcd67d41e  guix-build-4e8ab5e00fa7/output/riscv64-linux-gnu/SHA256SUMS.part
155966d6e7b358977224ba998884b9e2828e1533dc57460664490e650a7de3bbd7  guix-build-4e8ab5e00fa7/output/riscv64-linux-gnu/bitcoin-4e8ab5e00fa7-riscv64-linux-gnu-debug.tar.gz
1611b1e9eb344699db620323bc3d83ad7e0bc54900adfcdb1a78862aec87bf0ba7  guix-build-4e8ab5e00fa7/output/riscv64-linux-gnu/bitcoin-4e8ab5e00fa7-riscv64-linux-gnu.tar.gz
17d79665049c452b076aa15f6ec4df33b9abf5848be45ac3bff41a285407b78632  guix-build-4e8ab5e00fa7/output/x86_64-apple-darwin/SHA256SUMS.part
18683345f89433023d06a1ffdd56a1e3bd309e71c38fef25239e7a261787ee707b  guix-build-4e8ab5e00fa7/output/x86_64-apple-darwin/bitcoin-4e8ab5e00fa7-x86_64-apple-darwin-codesigning.tar.gz
1934912957d7084a2e634e0f0798cb8178727fc141f2df3defde5448fea06dc70c  guix-build-4e8ab5e00fa7/output/x86_64-apple-darwin/bitcoin-4e8ab5e00fa7-x86_64-apple-darwin-unsigned.tar.gz
206ebe05df5a752f27ac5069def88f4a3a6077d0515ead1cb67a737f8153ae6225  guix-build-4e8ab5e00fa7/output/x86_64-apple-darwin/bitcoin-4e8ab5e00fa7-x86_64-apple-darwin-unsigned.zip
21e11f942023d4e3a99fffe978c52fcb87bf2531c45e83e2cbcea2b127c0e1c827  guix-build-4e8ab5e00fa7/output/x86_64-linux-gnu/SHA256SUMS.part
2242b7393335551edb679e399dfc527ad7a163768b2c3c2a508f280af86b946405  guix-build-4e8ab5e00fa7/output/x86_64-linux-gnu/bitcoin-4e8ab5e00fa7-x86_64-linux-gnu-debug.tar.gz
2381b8402f1756241821662b67ab3a06b9c69e0b08fa36d0d271b1081c7388e1fd  guix-build-4e8ab5e00fa7/output/x86_64-linux-gnu/bitcoin-4e8ab5e00fa7-x86_64-linux-gnu.tar.gz
240f0507df76ef8c3e8f5c6b10ccbebfe7bbbb365e6315f35c4e7068b885ded800  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/SHA256SUMS.part
254a3db36c8d1efd1e9121f94f169b67ec724f967a0e2b8521bd5d037fac689654  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/bitcoin-4e8ab5e00fa7-win64-codesigning.tar.gz
26854e7057d6b1c5f8d33115ba50e0eb6bc08516d91584dadcf281c62551a9ded5  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/bitcoin-4e8ab5e00fa7-win64-debug.zip
27a5a8e9d3ce46948471d5d5789389a8ea1e3848daacd92d82f74867f47984adaf  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/bitcoin-4e8ab5e00fa7-win64-setup-unsigned.exe
28fab65537b33003a6a7d16f6b914252e71f371b34f0b89c5e852339521ee4cd86  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/bitcoin-4e8ab5e00fa7-win64-unsigned.zip

DrahtBot commented at 6:11 am on May 8, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit efac285a0d709f48856c37b15bfa09af94c1d75b(master)	commit 1a3670d4413332fd5786786ecc645dba964292e8(pull/32437/merge)
*-aarch64-linux-gnu-debug.tar.gz	`dd9795e914301c5d...`	`405c69965f3ee518...`
*-aarch64-linux-gnu.tar.gz	`fcee7e9fe2020fba...`	`cd92d82b06a973c9...`
*-arm-linux-gnueabihf-debug.tar.gz	`179fc9c91a9da4f5...`	`bc7c3564da677a72...`
*-arm-linux-gnueabihf.tar.gz	`16eda354a6089914...`	`ba3b5e265a46713b...`
*-arm64-apple-darwin-codesigning.tar.gz	`c781ae8206cd1c1d...`	`b03586cc03093024...`
*-arm64-apple-darwin-unsigned.tar.gz	`8d98bfaaaa4f66e1...`	`d3abd5235a9b2b99...`
*-arm64-apple-darwin-unsigned.zip	`0abf0b4e3d4f3306...`	`6aea05df83473640...`
*-powerpc64-linux-gnu-debug.tar.gz	`fe52bb3f5c189b2d...`	`5fa360f915098bc1...`
*-powerpc64-linux-gnu.tar.gz	`67a74d71993cfb2e...`	`b7d05502c4b73633...`
*-riscv64-linux-gnu-debug.tar.gz	`9acc01d1177d5ff5...`	`84242f05d4783b0e...`
*-riscv64-linux-gnu.tar.gz	`de982b0899fee2c2...`	`57e1d567d5efbe1f...`
*-x86_64-apple-darwin-codesigning.tar.gz	`1100904daf5d2d28...`	`0ab046ddbb25cd75...`
*-x86_64-apple-darwin-unsigned.tar.gz	`3c281f93fbc66f2b...`	`0aa48b6016726739...`
*-x86_64-apple-darwin-unsigned.zip	`50f379c75ea9292f...`	`b4ca9989f406ebe2...`
*-x86_64-linux-gnu-debug.tar.gz	`c7cbed8c9bc8308e...`	`179fce989f38b0d2...`
*-x86_64-linux-gnu.tar.gz	`1e8c046f8b772246...`	`737d1c6267af4c3c...`
*.tar.gz	`7cf53720fabe853f...`	`e5542a10e476ba83...`
SHA256SUMS.part	`3002ff81f6fc3c61...`	`4a89f9e59a62aeea...`
guix_build.log	`ad61e3dc1aadc2e9...`	`e77f2196cdea6363...`
guix_build.log.diff		`b4d7f35928c6cc6b...`

DrahtBot removed the label DrahtBot Guix build requested on May 8, 2025

davidgumberg commented at 7:25 am on May 8, 2025: contributor

Tested ACK https://github.com/bitcoin/bitcoin/pull/32437/commits/4e8ab5e00fa72016a7ec0e0505ca025d4e59e4d8

Fixes #31913, I built fuzzamoto against this branch (https://github.com/davidgumberg/fuzzamoto/commit/b15ed6222f2c1c7e43c8ddf163899413a9ef03ef).

fanquake merged this on May 8, 2025

fanquake closed this on May 8, 2025

fanquake deleted the branch on May 8, 2025

hebasto commented at 9:28 am on May 8, 2025: member

My Guix build:

 0aarch64
 120608607794819e22c0bc02c920ba03a4edf98b902e278f1e2dcc9d92f2f485f  guix-build-4e8ab5e00fa7/output/aarch64-linux-gnu/SHA256SUMS.part
 2f3268558a957a2b55191b14bdb9f7c23d60dc72a84ecbfe6b56a280f8f09fd1f  guix-build-4e8ab5e00fa7/output/aarch64-linux-gnu/bitcoin-4e8ab5e00fa7-aarch64-linux-gnu-debug.tar.gz
 3791e1b3e81b358343dd5fafa53ab1d503e819d6935515277443dcfef4091c470  guix-build-4e8ab5e00fa7/output/aarch64-linux-gnu/bitcoin-4e8ab5e00fa7-aarch64-linux-gnu.tar.gz
 41b689d1c92f6026d995479b469bdb27445c4d24211172b4df6d2a0154e3ec59b  guix-build-4e8ab5e00fa7/output/arm-linux-gnueabihf/SHA256SUMS.part
 5e0b9909538378698752be25ce2e4985686e3af4bb063e6e74d650ffa6c3e9499  guix-build-4e8ab5e00fa7/output/arm-linux-gnueabihf/bitcoin-4e8ab5e00fa7-arm-linux-gnueabihf-debug.tar.gz
 610bde1be812db42797de38fc8bb7bbe2539fb8aa2ddf44aef3eca80fb62d60ce  guix-build-4e8ab5e00fa7/output/arm-linux-gnueabihf/bitcoin-4e8ab5e00fa7-arm-linux-gnueabihf.tar.gz
 73180414f79510552b09e16691783fd31d1026e4ec4483ee35c92cb8b0fa4ff8d  guix-build-4e8ab5e00fa7/output/arm64-apple-darwin/SHA256SUMS.part
 8244b0c23873f5c2870f18248b4bc776b03a02d85bba52ae3129cbd18925e5b8f  guix-build-4e8ab5e00fa7/output/arm64-apple-darwin/bitcoin-4e8ab5e00fa7-arm64-apple-darwin-codesigning.tar.gz
 97e2ef8fd9be1a86f19ee681d5be02f5d1c383e609f83aed09bf1badbf8cdafa4  guix-build-4e8ab5e00fa7/output/arm64-apple-darwin/bitcoin-4e8ab5e00fa7-arm64-apple-darwin-unsigned.tar.gz
10d3849d36e7145d6bd6010c470bb0ea45541ffe9bed024d6af7a653bafde61abe  guix-build-4e8ab5e00fa7/output/arm64-apple-darwin/bitcoin-4e8ab5e00fa7-arm64-apple-darwin-unsigned.zip
11b09a548098729b646ccd1e5a3002876df0755da413d0b09c0a85d96fd89124e6  guix-build-4e8ab5e00fa7/output/dist-archive/bitcoin-4e8ab5e00fa7.tar.gz
12df546e3d6a4d0e5781e9850475021f6e000768ed8056052149a95159d560e0a3  guix-build-4e8ab5e00fa7/output/powerpc64-linux-gnu/SHA256SUMS.part
133f3c68023117391cb73569e250c236ba5173b56df44bfbf5fcc683c4c38ac886  guix-build-4e8ab5e00fa7/output/powerpc64-linux-gnu/bitcoin-4e8ab5e00fa7-powerpc64-linux-gnu-debug.tar.gz
144950dedd7b5d537d2e856e8ad3155edaabe28775acb7e5231b0115a4d10f8bbc  guix-build-4e8ab5e00fa7/output/powerpc64-linux-gnu/bitcoin-4e8ab5e00fa7-powerpc64-linux-gnu.tar.gz
15e7a06ec17074800ef71c8d8244bdb72c57e378c242731ed0bed3e10bcd67d41e  guix-build-4e8ab5e00fa7/output/riscv64-linux-gnu/SHA256SUMS.part
165966d6e7b358977224ba998884b9e2828e1533dc57460664490e650a7de3bbd7  guix-build-4e8ab5e00fa7/output/riscv64-linux-gnu/bitcoin-4e8ab5e00fa7-riscv64-linux-gnu-debug.tar.gz
1711b1e9eb344699db620323bc3d83ad7e0bc54900adfcdb1a78862aec87bf0ba7  guix-build-4e8ab5e00fa7/output/riscv64-linux-gnu/bitcoin-4e8ab5e00fa7-riscv64-linux-gnu.tar.gz
18d79665049c452b076aa15f6ec4df33b9abf5848be45ac3bff41a285407b78632  guix-build-4e8ab5e00fa7/output/x86_64-apple-darwin/SHA256SUMS.part
19683345f89433023d06a1ffdd56a1e3bd309e71c38fef25239e7a261787ee707b  guix-build-4e8ab5e00fa7/output/x86_64-apple-darwin/bitcoin-4e8ab5e00fa7-x86_64-apple-darwin-codesigning.tar.gz
2034912957d7084a2e634e0f0798cb8178727fc141f2df3defde5448fea06dc70c  guix-build-4e8ab5e00fa7/output/x86_64-apple-darwin/bitcoin-4e8ab5e00fa7-x86_64-apple-darwin-unsigned.tar.gz
216ebe05df5a752f27ac5069def88f4a3a6077d0515ead1cb67a737f8153ae6225  guix-build-4e8ab5e00fa7/output/x86_64-apple-darwin/bitcoin-4e8ab5e00fa7-x86_64-apple-darwin-unsigned.zip
22e11f942023d4e3a99fffe978c52fcb87bf2531c45e83e2cbcea2b127c0e1c827  guix-build-4e8ab5e00fa7/output/x86_64-linux-gnu/SHA256SUMS.part
2342b7393335551edb679e399dfc527ad7a163768b2c3c2a508f280af86b946405  guix-build-4e8ab5e00fa7/output/x86_64-linux-gnu/bitcoin-4e8ab5e00fa7-x86_64-linux-gnu-debug.tar.gz
2481b8402f1756241821662b67ab3a06b9c69e0b08fa36d0d271b1081c7388e1fd  guix-build-4e8ab5e00fa7/output/x86_64-linux-gnu/bitcoin-4e8ab5e00fa7-x86_64-linux-gnu.tar.gz
250f0507df76ef8c3e8f5c6b10ccbebfe7bbbb365e6315f35c4e7068b885ded800  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/SHA256SUMS.part
264a3db36c8d1efd1e9121f94f169b67ec724f967a0e2b8521bd5d037fac689654  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/bitcoin-4e8ab5e00fa7-win64-codesigning.tar.gz
27854e7057d6b1c5f8d33115ba50e0eb6bc08516d91584dadcf281c62551a9ded5  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/bitcoin-4e8ab5e00fa7-win64-debug.zip
28a5a8e9d3ce46948471d5d5789389a8ea1e3848daacd92d82f74867f47984adaf  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/bitcoin-4e8ab5e00fa7-win64-setup-unsigned.exe
29fab65537b33003a6a7d16f6b914252e71f371b34f0b89c5e852339521ee4cd86  guix-build-4e8ab5e00fa7/output/x86_64-w64-mingw32/bitcoin-4e8ab5e00fa7-win64-unsigned.zip

hebasto commented at 9:29 am on May 8, 2025: member

Post-merge ACK 4e8ab5e00fa72016a7ec0e0505ca025d4e59e4d8.

theuni commented at 1:39 pm on May 8, 2025: member

Post-merge ACK 4e8ab5e00fa72016a7ec0e0505ca025d4e59e4d8. Looks like the right fix to me.

crypto: disable ASan for sha256_sse4 with Clang #32437

Code Coverage & Benchmarks

Reviews

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]