test: remove bdb assert in tool_wallet.py #32440

1. 
   kevkevinpal commented at 4:24 pm on May 7, 2025: contributor

   As suggested in #32438 (comment)

   legacy wallet and the BDB dependency was removed (https://github.com/bitcoin/bitcoin/pull/28710) so this assert is safe to delete

2. 
   DrahtBot commented at 4:24 pm on May 7, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32440.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	brunoerg, davidgumberg, theStack, achow101
   Stale ACK	w0xlt

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on May 7, 2025
4. test: remove bdb assert in tool_wallet.py 4b6dd9790b
5. kevkevinpal force-pushed on May 7, 2025
6. DrahtBot added the label CI failed on May 7, 2025
7. 
   DrahtBot commented at 5:03 pm on May 7, 2025: contributor

   🚧 At least one of the CI tasks failed. Task lint: https://github.com/bitcoin/bitcoin/runs/41813985818 LLM reason (✨ experimental): The CI failure is due to a Python linting error: an unused variable was detected.

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

8. 
   davidgumberg commented at 5:46 pm on May 7, 2025: contributor

   crACK https://github.com/bitcoin/bitcoin/pull/32440/commits/4b6dd9790b667455ad7de58c67b3f7c9bc50657c
9. 
   w0xlt commented at 6:08 pm on May 7, 2025: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/32440/commits/4b6dd9790b667455ad7de58c67b3f7c9bc50657c
10. brunoerg approved
11. 
    brunoerg commented at 6:11 pm on May 7, 2025: contributor

    code review ACK 4b6dd9790b667455ad7de58c67b3f7c9bc50657c
12. theStack approved
13. 
    theStack commented at 6:15 pm on May 7, 2025: contributor

    ACK 4b6dd9790b667455ad7de58c67b3f7c9bc50657c

    If you want, could also remove assert_dump which is not used anymore since c847dee1488a294c9a9632a00ba1134b21e41947

14. test: remove assert_dump since it is not used anymore e08e6567f2
15. 
    kevkevinpal commented at 6:19 pm on May 7, 2025: contributor

    ACK 4b6dd97

    If you want, could also remove assert_dump which is not used anymore since c847dee

    Thanks for the suggestion!

    removed in e08e656

16. brunoerg approved
17. 
    brunoerg commented at 6:21 pm on May 7, 2025: contributor

    reACK e08e6567f2e7e3e3acaa038e3302f069b9a3c54c
18. DrahtBot requested review from w0xlt on May 7, 2025
19. DrahtBot requested review from davidgumberg on May 7, 2025
20. DrahtBot requested review from theStack on May 7, 2025
21. 
    davidgumberg commented at 6:22 pm on May 7, 2025: contributor

    reACK https://github.com/bitcoin/bitcoin/pull/32440/commits/e08e6567f2e7e3e3acaa038e3302f069b9a3c54c
22. theStack approved
23. 
    theStack commented at 6:25 pm on May 7, 2025: contributor

    re-ACK e08e6567f2e7e3e3acaa038e3302f069b9a3c54c
24. 
    achow101 commented at 6:33 pm on May 7, 2025: member

    ACK e08e6567f2e7e3e3acaa038e3302f069b9a3c54c
25. achow101 merged this on May 7, 2025
26. achow101 closed this on May 7, 2025

    ---

Contributors
kevkevinpal DrahtBot davidgumberg w0xlt brunoerg theStack achow101

Review Requested
davidgumberg w0xlt

Labels
Tests CI failed