tracing: fix invalid argument in mempool_monitor #32454

pull jb55 wants to merge 1 commits into bitcoin:master from jb55:fix-mempool-monitor changing 1 files +2 −2
  1. jb55 commented at 5:05 am on May 9, 2025: contributor

    The mempool_monitor tracing tool is incorrectly reading the reason as the first argument. Fix this!

    Noticed this during the bitcoin++ mempool hackathon 😅

    cc 0xB10C

  2. tracing: fix invalid argument in mempool_monitor
    The mempool_monitor tracing tool is incorrectly reading the reason
    as the first argument. Fix this!
    31c5ebc400
  3. DrahtBot commented at 5:05 am on May 9, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32454.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK 0xB10C

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. 0xB10C commented at 6:57 am on May 9, 2025: contributor

    Code Review ACK 31c5ebc4007884b655f2f90ca09e36e0b9ada4da

    Seems like I introduced that bug in #31848 (ec47ba349d0b3cb2d274593ca7b828ae70584e10).

  5. maflcko added the label Needs backport (29.x) on May 9, 2025
  6. maflcko added this to the milestone 29.1 on May 9, 2025
  7. fanquake merged this on May 9, 2025
  8. fanquake closed this on May 9, 2025

  9. fanquake referenced this in commit fabf4ff237 on May 9, 2025
  10. fanquake removed the label Needs backport (29.x) on May 9, 2025
  11. fanquake commented at 8:34 am on May 9, 2025: member
    Backported to 29.x in #32292.
  12. 0xB10C commented at 7:42 am on May 10, 2025: contributor
    This came to my mind again: We might want to consider maintaining these tools outside of the Bitcoin Core repo as mentioned in #31274 6)
  13. jb55 commented at 1:58 pm on May 10, 2025: contributor
    that makes sense to me


jb55 DrahtBot 0xB10C fanquake

Milestone
29.1


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-13 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me