tracing: fix invalid argument in mempool_monitor #32454

pull jb55 wants to merge 1 commits into bitcoin:master from jb55:fix-mempool-monitor changing 1 files +2 −2
  1. jb55 commented at 5:05 AM on May 9, 2025: contributor

    The mempool_monitor tracing tool is incorrectly reading the reason as the first argument. Fix this!

    Noticed this during the bitcoin++ mempool hackathon 😅

    cc 0xB10C

  2. tracing: fix invalid argument in mempool_monitor
    The mempool_monitor tracing tool is incorrectly reading the reason
    as the first argument. Fix this!
    31c5ebc400
  3. DrahtBot commented at 5:05 AM on May 9, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32454.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK 0xB10C

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. 0xB10C commented at 6:57 AM on May 9, 2025: contributor

    Code Review ACK 31c5ebc4007884b655f2f90ca09e36e0b9ada4da

    Seems like I introduced that bug in #31848 (ec47ba349d0b3cb2d274593ca7b828ae70584e10).

  5. maflcko added the label Needs backport (29.x) on May 9, 2025
  6. maflcko added this to the milestone 29.1 on May 9, 2025
  7. fanquake merged this on May 9, 2025
  8. fanquake closed this on May 9, 2025

  9. fanquake referenced this in commit fabf4ff237 on May 9, 2025
  10. fanquake removed the label Needs backport (29.x) on May 9, 2025
  11. fanquake commented at 8:34 AM on May 9, 2025: member

    Backported to 29.x in #32292.

  12. 0xB10C commented at 7:42 AM on May 10, 2025: contributor

    This came to my mind again: We might want to consider maintaining these tools outside of the Bitcoin Core repo as mentioned in #31274 6)

  13. jb55 commented at 1:58 PM on May 10, 2025: contributor

    that makes sense to me

  14. fanquake referenced this in commit 589b56192f on May 22, 2025
  15. stickies-v referenced this in commit 772a33e052 on May 23, 2025
  16. sedited referenced this in commit cb3cd9b8b9 on May 29, 2025
  17. yuvicc referenced this in commit 069643f094 on Jul 6, 2025
  18. bug-castercv502 referenced this in commit 2858098810 on Sep 28, 2025
  19. morozow referenced this in commit cabc6d4948 on May 8, 2026
  20. morozow referenced this in commit edc6b10728 on May 8, 2026
  21. Kino1994 referenced this in commit c70f4a0ae8 on Jun 28, 2026
  22. BigcoinBGC referenced this in commit b8c10412dc on Jun 30, 2026
  23. bitcoin locked this on Jul 30, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-10 22:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me