guix: move `*-check.py` scripts under contrib/guix/

fanquake commented at 12:54 pm on May 9, 2025: member

These scripts are not meant for general developer usage. They are for use on the release binaries, which have been compiled in an environment that makes various assumptions in regards to c library, compiler options, hardening options, dependency patching etc.

Anyone is free to run these scripts against self-compiled binaries, but this isn’t something we want to modify/generalize the scripts to support.

guix: move *-check.py scripts under contrib/guix

These scripts are not meant for general developer usage. They are for
use on the release binaries, which have been compiled in an environment
that makes various assumptions in regards to c library, compiler
options, hardening options, patching etc.

415650cea9

DrahtBot commented at 12:54 pm on May 9, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32458.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	laanwj, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#31233 (cmake: Improve robustness and usability by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Build system on May 9, 2025

TheCharlatan commented at 1:20 pm on May 9, 2025: contributor

Concept ACK

fanquake commented at 1:46 pm on May 9, 2025: member

Guix Build:

 0f15ff81485789fe4fa22c3ecf887cfbfa0b3ae8620fd8c8926deb257ef19cff9  guix-build-415650cea94f/output/aarch64-linux-gnu/SHA256SUMS.part
 17320f11f0ff5005d841dc2d854f46c5d317df077dae41b4631493f090b34875c  guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu-debug.tar.gz
 2af696399978c60a9517006c8435d8053b541b3dcfec49dacaa46932404d22b7b  guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu.tar.gz
 36da90889d6dcb60093136249bafa31db179f436a22977308c7c74690183beecf  guix-build-415650cea94f/output/arm-linux-gnueabihf/SHA256SUMS.part
 49e5cb55d04c38db37a6780cf13ade4af2629b3a90ccd37bfc55e8f22a5f6802b  guix-build-415650cea94f/output/arm-linux-gnueabihf/bitcoin-415650cea94f-arm-linux-gnueabihf-debug.tar.gz
 5643b6f6cca33b2173564bacb60d825fd1a48b83c8c395bf72b604f2c07411d7e  guix-build-415650cea94f/output/arm-linux-gnueabihf/bitcoin-415650cea94f-arm-linux-gnueabihf.tar.gz
 6bfb765b4a37eae8eca2f49f355bc44f86091c779c70b771ff952826790b07acc  guix-build-415650cea94f/output/arm64-apple-darwin/SHA256SUMS.part
 7327b6acf4865dda2a1fe92f78d8225d6613573e9c0d54ccad9f0baf6e091eb9b  guix-build-415650cea94f/output/arm64-apple-darwin/bitcoin-415650cea94f-arm64-apple-darwin-codesigning.tar.gz
 83bff66b7c3a7fe8b585ab0b0786b47a327f4e5c043d8ad26cce5bc85b1cdbb7b  guix-build-415650cea94f/output/arm64-apple-darwin/bitcoin-415650cea94f-arm64-apple-darwin-unsigned.tar.gz
 91f5f2650505f7dbc56353c91b2cc1c12e39ce0f4bcaee3dd678f0e129cb66d20  guix-build-415650cea94f/output/arm64-apple-darwin/bitcoin-415650cea94f-arm64-apple-darwin-unsigned.zip
10d9385788fd4e19caa4ef85959c285184026396abdbb0faf8f908c441e869e0ba  guix-build-415650cea94f/output/dist-archive/bitcoin-415650cea94f.tar.gz
1197a0f6a9e625d0884a6290198ee6129aa44bf6667e466acccd8129950fc737a5  guix-build-415650cea94f/output/powerpc64-linux-gnu/SHA256SUMS.part
1261ae3700a6c6e5c3b21fba74df84267242487719e7ab2459d0de79b71b3c9ea3  guix-build-415650cea94f/output/powerpc64-linux-gnu/bitcoin-415650cea94f-powerpc64-linux-gnu-debug.tar.gz
13e2312020c04a222d3a598d5460bee957aed5c515e9a39405061047d7c07a3cf3  guix-build-415650cea94f/output/powerpc64-linux-gnu/bitcoin-415650cea94f-powerpc64-linux-gnu.tar.gz
14b8b90445ed29bc100c2f9a2a3851a8a6663f220005e6dfef68c8261e0c8d91e3  guix-build-415650cea94f/output/riscv64-linux-gnu/SHA256SUMS.part
1569f07f00be84424c307d2459afba324ff25f8c47d8aa314631de2f37ec224e52  guix-build-415650cea94f/output/riscv64-linux-gnu/bitcoin-415650cea94f-riscv64-linux-gnu-debug.tar.gz
16c1f72cb7bf768e0ad66743693076d520b6975556dad51cd36c5620acc539f25c  guix-build-415650cea94f/output/riscv64-linux-gnu/bitcoin-415650cea94f-riscv64-linux-gnu.tar.gz
17fa98a6cce7377a325686ce53770dc999e9ff2a4d723b34c8f3786810ee95fa34  guix-build-415650cea94f/output/x86_64-apple-darwin/SHA256SUMS.part
181a0a1359141bf6ecfe8e9f67988ac6b2fbbdaa48fca325afe04afc0da458796e  guix-build-415650cea94f/output/x86_64-apple-darwin/bitcoin-415650cea94f-x86_64-apple-darwin-codesigning.tar.gz
196fbeaabe44ab5538941e5baeba5dbf2e3d00312d0d79c4ce9ac68350d9e47a48  guix-build-415650cea94f/output/x86_64-apple-darwin/bitcoin-415650cea94f-x86_64-apple-darwin-unsigned.tar.gz
20632981933fe1c2997dceb5e4aba00ebf06276f84957bb0a95796e304fc7269ba  guix-build-415650cea94f/output/x86_64-apple-darwin/bitcoin-415650cea94f-x86_64-apple-darwin-unsigned.zip
21fcb73f8d11ed2f3bbf6a1a9c4f50edeb50a476881f2ea5f7118952c0108aeeb6  guix-build-415650cea94f/output/x86_64-linux-gnu/SHA256SUMS.part
22d1cde650cc54d213b79a20e4e9d23af4177580d5df3bd1019dd7371fb49c1e92  guix-build-415650cea94f/output/x86_64-linux-gnu/bitcoin-415650cea94f-x86_64-linux-gnu-debug.tar.gz
23094fe3ef124278a55baf70a8f70de82114fa9b7ce91d008864e38eb620a3ef24  guix-build-415650cea94f/output/x86_64-linux-gnu/bitcoin-415650cea94f-x86_64-linux-gnu.tar.gz
247e7dfe43ba9393d6b3575df9950b6feeedc5e44e923d77d0abe37dc15b9cba49  guix-build-415650cea94f/output/x86_64-w64-mingw32/SHA256SUMS.part
251175fd40f98f2ca05cb59ab1da2592bc94b25de2f0142971cd1c5b88ddd109cc  guix-build-415650cea94f/output/x86_64-w64-mingw32/bitcoin-415650cea94f-win64-codesigning.tar.gz
265fb984917fa6a618274788bb79740a6d5f1c3ddc54c26e1399906fec118b2a27  guix-build-415650cea94f/output/x86_64-w64-mingw32/bitcoin-415650cea94f-win64-debug.zip
27fd44497af0d338406622c3b686575584bce681a8029e393e6a420d301b384901  guix-build-415650cea94f/output/x86_64-w64-mingw32/bitcoin-415650cea94f-win64-setup-unsigned.exe
28c908d92b9b5acfd9c5d5ac626ec7fc99e474190250726815b543a07544c802d1  guix-build-415650cea94f/output/x86_64-w64-mingw32/bitcoin-415650cea94f-win64-unsigned.zip

laanwj approved

laanwj commented at 2:22 pm on May 9, 2025: member

Code review ACK 415650cea94f5050d7c368fdf9fd9878809957e1

DrahtBot requested review from TheCharlatan on May 9, 2025

TheCharlatan approved

TheCharlatan commented at 10:42 am on May 12, 2025: contributor

ACK 415650cea94f5050d7c368fdf9fd9878809957e1

Guix build matches.

fanquake merged this on May 12, 2025

fanquake closed this on May 12, 2025

fanquake deleted the branch on May 12, 2025

hebasto commented at 6:53 pm on May 12, 2025: member

My Guix build:

 0aarch64
 1f15ff81485789fe4fa22c3ecf887cfbfa0b3ae8620fd8c8926deb257ef19cff9  guix-build-415650cea94f/output/aarch64-linux-gnu/SHA256SUMS.part
 27320f11f0ff5005d841dc2d854f46c5d317df077dae41b4631493f090b34875c  guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu-debug.tar.gz
 3af696399978c60a9517006c8435d8053b541b3dcfec49dacaa46932404d22b7b  guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu.tar.gz
 46da90889d6dcb60093136249bafa31db179f436a22977308c7c74690183beecf  guix-build-415650cea94f/output/arm-linux-gnueabihf/SHA256SUMS.part
 59e5cb55d04c38db37a6780cf13ade4af2629b3a90ccd37bfc55e8f22a5f6802b  guix-build-415650cea94f/output/arm-linux-gnueabihf/bitcoin-415650cea94f-arm-linux-gnueabihf-debug.tar.gz
 6643b6f6cca33b2173564bacb60d825fd1a48b83c8c395bf72b604f2c07411d7e  guix-build-415650cea94f/output/arm-linux-gnueabihf/bitcoin-415650cea94f-arm-linux-gnueabihf.tar.gz
 7bfb765b4a37eae8eca2f49f355bc44f86091c779c70b771ff952826790b07acc  guix-build-415650cea94f/output/arm64-apple-darwin/SHA256SUMS.part
 8327b6acf4865dda2a1fe92f78d8225d6613573e9c0d54ccad9f0baf6e091eb9b  guix-build-415650cea94f/output/arm64-apple-darwin/bitcoin-415650cea94f-arm64-apple-darwin-codesigning.tar.gz
 93bff66b7c3a7fe8b585ab0b0786b47a327f4e5c043d8ad26cce5bc85b1cdbb7b  guix-build-415650cea94f/output/arm64-apple-darwin/bitcoin-415650cea94f-arm64-apple-darwin-unsigned.tar.gz
101f5f2650505f7dbc56353c91b2cc1c12e39ce0f4bcaee3dd678f0e129cb66d20  guix-build-415650cea94f/output/arm64-apple-darwin/bitcoin-415650cea94f-arm64-apple-darwin-unsigned.zip
11d9385788fd4e19caa4ef85959c285184026396abdbb0faf8f908c441e869e0ba  guix-build-415650cea94f/output/dist-archive/bitcoin-415650cea94f.tar.gz
1297a0f6a9e625d0884a6290198ee6129aa44bf6667e466acccd8129950fc737a5  guix-build-415650cea94f/output/powerpc64-linux-gnu/SHA256SUMS.part
1361ae3700a6c6e5c3b21fba74df84267242487719e7ab2459d0de79b71b3c9ea3  guix-build-415650cea94f/output/powerpc64-linux-gnu/bitcoin-415650cea94f-powerpc64-linux-gnu-debug.tar.gz
14e2312020c04a222d3a598d5460bee957aed5c515e9a39405061047d7c07a3cf3  guix-build-415650cea94f/output/powerpc64-linux-gnu/bitcoin-415650cea94f-powerpc64-linux-gnu.tar.gz
15b8b90445ed29bc100c2f9a2a3851a8a6663f220005e6dfef68c8261e0c8d91e3  guix-build-415650cea94f/output/riscv64-linux-gnu/SHA256SUMS.part
1669f07f00be84424c307d2459afba324ff25f8c47d8aa314631de2f37ec224e52  guix-build-415650cea94f/output/riscv64-linux-gnu/bitcoin-415650cea94f-riscv64-linux-gnu-debug.tar.gz
17c1f72cb7bf768e0ad66743693076d520b6975556dad51cd36c5620acc539f25c  guix-build-415650cea94f/output/riscv64-linux-gnu/bitcoin-415650cea94f-riscv64-linux-gnu.tar.gz
18fa98a6cce7377a325686ce53770dc999e9ff2a4d723b34c8f3786810ee95fa34  guix-build-415650cea94f/output/x86_64-apple-darwin/SHA256SUMS.part
191a0a1359141bf6ecfe8e9f67988ac6b2fbbdaa48fca325afe04afc0da458796e  guix-build-415650cea94f/output/x86_64-apple-darwin/bitcoin-415650cea94f-x86_64-apple-darwin-codesigning.tar.gz
206fbeaabe44ab5538941e5baeba5dbf2e3d00312d0d79c4ce9ac68350d9e47a48  guix-build-415650cea94f/output/x86_64-apple-darwin/bitcoin-415650cea94f-x86_64-apple-darwin-unsigned.tar.gz
21632981933fe1c2997dceb5e4aba00ebf06276f84957bb0a95796e304fc7269ba  guix-build-415650cea94f/output/x86_64-apple-darwin/bitcoin-415650cea94f-x86_64-apple-darwin-unsigned.zip
22fcb73f8d11ed2f3bbf6a1a9c4f50edeb50a476881f2ea5f7118952c0108aeeb6  guix-build-415650cea94f/output/x86_64-linux-gnu/SHA256SUMS.part
23d1cde650cc54d213b79a20e4e9d23af4177580d5df3bd1019dd7371fb49c1e92  guix-build-415650cea94f/output/x86_64-linux-gnu/bitcoin-415650cea94f-x86_64-linux-gnu-debug.tar.gz
24094fe3ef124278a55baf70a8f70de82114fa9b7ce91d008864e38eb620a3ef24  guix-build-415650cea94f/output/x86_64-linux-gnu/bitcoin-415650cea94f-x86_64-linux-gnu.tar.gz
257e7dfe43ba9393d6b3575df9950b6feeedc5e44e923d77d0abe37dc15b9cba49  guix-build-415650cea94f/output/x86_64-w64-mingw32/SHA256SUMS.part
261175fd40f98f2ca05cb59ab1da2592bc94b25de2f0142971cd1c5b88ddd109cc  guix-build-415650cea94f/output/x86_64-w64-mingw32/bitcoin-415650cea94f-win64-codesigning.tar.gz
275fb984917fa6a618274788bb79740a6d5f1c3ddc54c26e1399906fec118b2a27  guix-build-415650cea94f/output/x86_64-w64-mingw32/bitcoin-415650cea94f-win64-debug.zip
28fd44497af0d338406622c3b686575584bce681a8029e393e6a420d301b384901  guix-build-415650cea94f/output/x86_64-w64-mingw32/bitcoin-415650cea94f-win64-setup-unsigned.exe
29c908d92b9b5acfd9c5d5ac626ec7fc99e474190250726815b543a07544c802d1  guix-build-415650cea94f/output/x86_64-w64-mingw32/bitcoin-415650cea94f-win64-unsigned.zip

hebasto commented at 6:54 pm on May 12, 2025: member

Post-merge ACK 415650cea94f5050d7c368fdf9fd9878809957e1.

guix: move *-check.py scripts under contrib/guix/ #32458

Code Coverage & Benchmarks

Reviews

Conflicts

guix: move `*-check.py` scripts under contrib/guix/ #32458