The watch-only functionality in the GUI was only used for legacy wallets. Watch-only descriptor wallets do not use this.
The only visible changes of this PR should be:
This PR also removes some unused variables from the interface.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32459.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Stale ACK | achow101 |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
316@@ -317,12 +317,9 @@ QT_TRANSLATE_NOOP("bitcoin-core", "Error reading configuration file: %s"),
317 QT_TRANSLATE_NOOP("bitcoin-core", "Error reading from database, shutting down."),
318 QT_TRANSLATE_NOOP("bitcoin-core", "Error reading next record from wallet database"),
319 QT_TRANSLATE_NOOP("bitcoin-core", "Error: Cannot extract destination from the generated scriptpubkey"),
320-QT_TRANSLATE_NOOP("bitcoin-core", "Error: Could not add watchonly tx %s to watchonly wallet"),
I think we shouldn’t touch this file in this PR:
53@@ -54,9 +54,9 @@ class TransactionView : public QWidget
54
55 enum ColumnWidths {
56 STATUS_COLUMN_WIDTH = 30,
57- WATCHONLY_COLUMN_WIDTH = 23,
58 DATE_COLUMN_WIDTH = 120,
59 TYPE_COLUMN_WIDTH = 113,
60+ LABEL_MINIMUM_COLUMN_WIDTH = 120,
Are these lines still necessary:
I got rid of them.
For some reason QT is hiding column 1, which happens to be the date, but it also happens if I e.g. swap the date and type column.
Aha, QT caches column layout between sessions, so it remembers how this column behaved on an earlier run.
Are these lines still necessary:
I got rid of them.
For some reason QT is hiding column 1, which happens to be the date, but it also happens if I e.g. swap the date and type column.
Aha, QT caches column layout between sessions, so it remembers how this column behaved on an earlier run.
^ Indeed.
TransactionViewHeaderState so that it’s reset. This prevents hiding the date column.
I renamed
TransactionViewHeaderStateso that it’s reset. This prevents hiding the date column.
A more general approach would involve versioning, though.
Added a release note.
A more general approach would involve versioning
I’m open to suggestions. Though this screen is unlikely to change again between now and when we switch to QML.
ACK 0fc9bf05c36169ff746df10c5c8310f5adf2e202
There does not appear to be any visual differences, nor any remaining references to watch-only/watchonly in the GUI.
src/qt/forms/overviewpage.ui, after removing all items from row="0" of the gridLayout element, all subsequent rows should be renumbered as follows: 1 -> 0, 2 -> 1, 3 -> 2, 4 -> 3, 5 -> 4.
The watch-only functionality in the GUI was only used for legacy wallets.
Watch-only descriptor wallets do not use this.
The only visible changes of this commit are:
- dropped "Spendable:" label from the overview tab
- column width cache is reset
overviewpage.ui.
