test: add skip_if_running_under_valgrind() #32492

1. 
   fanquake commented at 9:58 AM on May 14, 2025: member

   Enable it in the USDT tests. The context (from 0xB10C):

   every time the tracepoint is reached a SIGTRAP is fired. No matter the tracepoint contents, even with an empty one. Valgrind intercepts SIGTRAP and aborts.

   See discussion in #32374.

2. test: add skip_if_running_under_valgrind()

   Enable it in the USDT tests. The context (from 0xB10C):
   
   > every time the tracepoint is reached a SIGTRAP is fired.
   > No matter the tracepoint contents, even with an empty one.
   > Valgrind intercepts SIGTRAP and aborts.
   
   See discussion in #32374.

   75a185ea3d
3. fanquake requested review from willcl-ark on May 14, 2025
4. fanquake requested review from 0xB10C on May 14, 2025
5. 
   DrahtBot commented at 9:58 AM on May 14, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32492.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, willcl-ark

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

6. DrahtBot added the label Tests on May 14, 2025
7. 
   maflcko commented at 11:36 AM on May 14, 2025: member

   lgtm ACK 75a185ea3db3177e8e479ee61a39bcb51e08d9a6

   I haven't tested or confirmed this, but the diff looks plausible.

8. willcl-ark approved
9. 
   willcl-ark commented at 9:04 PM on May 14, 2025: member

   ACK 75a185ea3db3177e8e479ee61a39bcb51e08d9a6

   Very lightly tested. Code changes look correct to me too.

   <details> <summary>Details</summary>

   bitcoin on  functional_tracepoints_skip_valgrind:refs/pull/32492/head [$!] via △ v3.30.5 via 🐍 v3.12.7 via ❄️  impure (nix-shell-env) took 6s
   ❯ build/test/functional/interface_usdt_coinselection.py --valgrind
   2025-05-14T21:03:58.758000Z TestFramework (INFO): PRNG seed is: 5177280005936620294
   2025-05-14T21:03:58.758000Z TestFramework (WARNING): Test Skipped: This test is not compatible with Valgrind.
   2025-05-14T21:03:58.808000Z TestFramework (INFO): Stopping nodes
   2025-05-14T21:03:58.808000Z TestFramework (INFO): Cleaning up /tmp/bitcoin_func_test_uohqz7dn on exit
   2025-05-14T21:03:58.808000Z TestFramework (INFO): Test skipped
   

   </details>

10. fanquake merged this on May 15, 2025
11. fanquake closed this on May 15, 2025

    ---

12. fanquake deleted the branch on May 15, 2025
13. stickies-v referenced this in commit 772a33e052 on May 23, 2025
14. sedited referenced this in commit cb3cd9b8b9 on May 29, 2025
15. 
    0xB10C commented at 10:35 AM on June 3, 2025: contributor

    LGTM post-merge ACK

16. yuvicc referenced this in commit 069643f094 on Jul 6, 2025
17. bug-castercv502 referenced this in commit 2858098810 on Sep 28, 2025
18. Kino1994 referenced this in commit 77159f296f on Jun 28, 2026
19. BigcoinBGC referenced this in commit 15742dd7c0 on Jun 30, 2026
20. bitcoin locked this on Jul 30, 2026

Review Requested
0xB10C