depends: drop ltcg
for Windows Qt
#32496
pull
fanquake
wants to merge
1
commits into
bitcoin:master
from
fanquake:depends_qt_ltcg
changing
1
files
+0 −3
-
fanquake commented at 11:45 am on May 14, 2025: memberThe related Windows patches were dropped in 5e794e62024eef612e1fbb71c76ea54d17435c14, and “Cross-compiling does not support LTO.” (from #30997).
-
DrahtBot commented at 11:45 am on May 14, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32496.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Build system on May 14, 2025
-
fanquake requested review from hebasto on Jun 3, 2025
-
depends: remove support for Windows Qt LTO builds
The patches needed to support this were dropped in 5e794e62024eef612e1fbb71c76ea54d17435c14 and "Cross-compiling does not support LTO." (from #30997), so remove it for now.
-
fanquake renamed this:
depends: add Qt `-ltcg` for Darwin, drop it for Windows
depends: drop `ltcg` for Windows Qt
on Jun 4, 2025 -
fanquake force-pushed on Jun 4, 2025
-
fanquake commented at 1:56 pm on June 4, 2025: memberQt + lto works for native, but is broken for Darwin cross builds, so dropped the second commit.
-
maflcko commented at 2:56 pm on June 4, 2025: memberlgtm ACK 9653ebc053602a30aee6d8676913306d615841cf
-
fanquake merged this on Jun 5, 2025
-
fanquake closed this on Jun 5, 2025
-
fanquake deleted the branch on Jun 5, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-01 15:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-01 15:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me