The related Windows patches were dropped in 5e794e62024eef612e1fbb71c76ea54d17435c14, and "Cross-compiling does not support LTO." (from #30997).
depends: drop `ltcg` for Windows Qt #32496
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends_qt_ltcg changing 1 files +0 −3-
fanquake commented at 11:45 AM on May 14, 2025: member
-
DrahtBot commented at 11:45 AM on May 14, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32496.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label Build system on May 14, 2025
- fanquake requested review from hebasto on Jun 3, 2025
-
9653ebc053
depends: remove support for Windows Qt LTO builds
The patches needed to support this were dropped in 5e794e62024eef612e1fbb71c76ea54d17435c14 and "Cross-compiling does not support LTO." (from #30997), so remove it for now.
- fanquake renamed this:
depends: add Qt `-ltcg` for Darwin, drop it for Windows
depends: drop `ltcg` for Windows Qt
on Jun 4, 2025 - fanquake force-pushed on Jun 4, 2025
-
fanquake commented at 1:56 PM on June 4, 2025: member
Qt + lto works for native, but is broken for Darwin cross builds, so dropped the second commit.
-
maflcko commented at 2:56 PM on June 4, 2025: member
lgtm ACK 9653ebc053602a30aee6d8676913306d615841cf
- fanquake merged this on Jun 5, 2025
- fanquake closed this on Jun 5, 2025
- fanquake deleted the branch on Jun 5, 2025
Labels