init: drop `-upnp` #32500

1. 
   fanquake commented at 3:05 PM on May 14, 2025: member

   This was slated for removal in 30.0, so remove it.

2. init: drop -upnp

   This was slated for removal in 30.0, so remove it.

   301993ebf7
3. fanquake added this to the milestone 30.0 on May 14, 2025
4. 
   DrahtBot commented at 3:06 PM on May 14, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32500.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	i-am-yuvi, darosior, maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

5. 
   maflcko commented at 3:17 PM on May 14, 2025: member

   No objection, but if this reintroduces the settings.json error, I can also see waiting one more release (or so), because the migration code looks minimal and harmless.

6. 
   fanquake commented at 3:20 PM on May 14, 2025: member

   Yea I don't mind. I guess we'll have to touch this in either case, as we shouldn't have a note saying to remove things in 30.x, if they aren't being removed in 30.x.

7. 
   i-am-yuvi commented at 6:34 AM on May 15, 2025: contributor

   ACK 301993ebf7f8ec23050e91377e0fd05823bb372a

8. 
   darosior commented at 8:17 PM on May 15, 2025: member

   if this reintroduces the settings.json error, I can also see waiting one more release

   An unknown upnp entry in settings.json would just be ignored? A upnp entry in the config file would cause a startup failure. Concept ACK on this basis.

9. darosior approved
10. 
    darosior commented at 8:33 PM on May 15, 2025: member

    An unknown upnp entry in settings.json would just be ignored?

    Confirmed.

    tACK 301993ebf7f8ec23050e91377e0fd05823bb372a

11. 
    maflcko commented at 6:55 AM on May 16, 2025: member

    An unknown upnp entry in settings.json would just be ignored?

    Confirmed.

    Thanks for checking. I guess I was confused and the comment added in https://github.com/bitcoin/bitcoin/pull/31198/files was wrong?

    review ACK 301993ebf7f8ec23050e91377e0fd05823bb372a

    Also checked that unknown entries are ignored.

12. fanquake merged this on May 16, 2025
13. fanquake closed this on May 16, 2025

    ---

14. fanquake deleted the branch on May 16, 2025

Milestone
30.0