Fixes #29466
Update removeprunedfunds
RPC to take an array of strings of txids
instead of a single txid string
to allow batch removal of transactions
Fixes #29466
Update removeprunedfunds
RPC to take an array of strings of txids
instead of a single txid string
to allow batch removal of transactions
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32501.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
Concept NACK | luke-jr |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
@BrandonOdiwuor I don’t think it’s productive to open a draft PR without first addressing the comments. If you’d like to continue working on this but are facing blockers, it would be better to communicate your approach and explain where you’re stuck in the tracking issue.
I suggest closing this for now and reopening it once the concerns raised about the previous approach have been addressed.
Closing for now. I don’t think there is any need in opening a pull request that is just a previously closed pull request with:
Contributions are welcome. Just make sure to run the tests before opening a pull request. Also, pre-existing review feedback would be good to address before opening a pull request.