RPC: removeprunedfunds should take an array of txids #32501

pull BrandonOdiwuor wants to merge 1 commits into bitcoin:master from BrandonOdiwuor:removeprunedfunds-array changing 3 files +30 −13
  1. BrandonOdiwuor commented at 5:35 pm on May 14, 2025: contributor

    Fixes #29466

    Update removeprunedfunds RPC to take an array of strings of txids instead of a single txid string to allow batch removal of transactions

  2. RPC: removeprunedfunds should take an array of txids f02276b03e
  3. DrahtBot commented at 5:35 pm on May 14, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32501.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32514 (scripted-diff: Remove unused leading newline in RPC docs by maflcko)
    • #32238 (qt, wallet: Convert uint256 to Txid by marcofleon)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label RPC/REST/ZMQ on May 14, 2025
  5. DrahtBot added the label CI failed on May 14, 2025
  6. stickies-v commented at 8:54 pm on May 14, 2025: contributor
    This seems very similar to the approach taken in #29468. There were a couple of unaddressed review comments that seem to apply here too, so I think it would be good to list and address them. Furthermore, it might be appropriate to credit the original author?
  7. ismaelsadeeq commented at 9:09 pm on May 14, 2025: member

    @BrandonOdiwuor I don’t think it’s productive to open a draft PR without first addressing the comments. If you’d like to continue working on this but are facing blockers, it would be better to communicate your approach and explain where you’re stuck in the tracking issue.

    I suggest closing this for now and reopening it once the concerns raised about the previous approach have been addressed.

  8. DrahtBot added the label Needs rebase on May 16, 2025
  9. DrahtBot commented at 9:21 am on May 16, 2025: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-19 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me