wallet: Drop unused fFromMe from CWalletTx #32502

pull davidgumberg wants to merge 1 commits into bitcoin:master from davidgumberg:5-14-25-dead-code-removal changing 2 files +4 −13
  1. davidgumberg commented at 6:26 pm on May 14, 2025: contributor
    This has been unused since commit fe52346, this is a re-opening of #9351.
  2. wallet: Drop unused fFromMe from CWalletTx
    This has been unused since commit fe52346, previously attempted to be
    removed in PR #9351 (https://github.com/bitcoin/bitcoin/pull/9351/)
    
    Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
    5bf91ba880
  3. DrahtBot commented at 6:26 pm on May 14, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32502.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Wallet on May 14, 2025
  5. maflcko commented at 6:35 pm on May 14, 2025: member
    lgtm ACK 5bf91ba8800d23402536d758f02198eac0fd7d61
  6. maflcko commented at 6:36 pm on May 14, 2025: member
    (please no @ in the pull description, otherwise people will get pinged for every cherry-pick of the merge commit, which includes this)
  7. davidgumberg commented at 6:38 pm on May 14, 2025: contributor

    (please no @ in the pull description, otherwise people will get pinged for every cherry-pick of the merge commit, which includes this)

    Fixed, thanks.

  8. achow101 commented at 9:58 pm on May 14, 2025: member
    ACK 5bf91ba8800d23402536d758f02198eac0fd7d61
  9. achow101 merged this on May 14, 2025
  10. achow101 closed this on May 14, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-30 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me