This has been unused since commit fe52346, this is a re-opening of #9351.
wallet: Drop unused fFromMe from CWalletTx #32502
pull davidgumberg wants to merge 1 commits into bitcoin:master from davidgumberg:5-14-25-dead-code-removal changing 2 files +4 −13-
davidgumberg commented at 6:26 PM on May 14, 2025: contributor
-
5bf91ba880
wallet: Drop unused fFromMe from CWalletTx
This has been unused since commit fe52346, previously attempted to be removed in PR #9351 (https://github.com/bitcoin/bitcoin/pull/9351/) Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
-
DrahtBot commented at 6:26 PM on May 14, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32502.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label Wallet on May 14, 2025
-
maflcko commented at 6:35 PM on May 14, 2025: member
lgtm ACK 5bf91ba8800d23402536d758f02198eac0fd7d61
-
maflcko commented at 6:36 PM on May 14, 2025: member
(please no
@in the pull description, otherwise people will get pinged for every cherry-pick of the merge commit, which includes this) -
davidgumberg commented at 6:38 PM on May 14, 2025: contributor
(please no
@in the pull description, otherwise people will get pinged for every cherry-pick of the merge commit, which includes this)Fixed, thanks.
-
achow101 commented at 9:58 PM on May 14, 2025: member
ACK 5bf91ba8800d23402536d758f02198eac0fd7d61
- achow101 merged this on May 14, 2025
- achow101 closed this on May 14, 2025
- stickies-v referenced this in commit 772a33e052 on May 23, 2025
- sedited referenced this in commit cb3cd9b8b9 on May 29, 2025
- yuvicc referenced this in commit 069643f094 on Jul 6, 2025
- bug-castercv502 referenced this in commit 2858098810 on Sep 28, 2025
- Kino1994 referenced this in commit 9b19873277 on Jun 28, 2026
- BigcoinBGC referenced this in commit 022a66ada5 on Jun 30, 2026
- bitcoin locked this on Jul 30, 2026
Contributors
Labels