ci: Exclude failing wallet_reorgsrestore.py from valgrind task for now #32507

1. 
   maflcko commented at 10:59 am on May 15, 2025: member

   Fixes #32493

   For some reason terminate or kill do not work inside the CI system under valgrind.

   So disable the test for now, until a solution is found.

2. ci: Exclude failing wallet_reorgsrestore.py from valgrind task for now fa981b90f5
3. 
   DrahtBot commented at 10:59 am on May 15, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32507.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake, mzumsande

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on May 15, 2025
5. fanquake approved
6. 
   fanquake commented at 11:20 am on May 15, 2025: member

   ACK fa981b90f53101bff2eda606d9479233e71736b5
7. 
   furszy commented at 2:26 pm on May 15, 2025: member

   What if instead of excluding the entire test file, we only exclude the specific failing test case?

    0diff --git a/test/functional/wallet_reorgsrestore.py b/test/functional/wallet_reorgsrestore.py
    1--- a/test/functional/wallet_reorgsrestore.py	(revision 8d5a11f34157934d9aecf8d5535ec3c17b13fcf3)
    2+++ b/test/functional/wallet_reorgsrestore.py	(date 1747319065527)
    3@@ -14,6 +14,7 @@
    4 """
    5 
    6 from decimal import Decimal
    7+import os
    8 import shutil
    9 
   10 from test_framework.test_framework import BitcoinTestFramework
   11@@ -90,6 +91,12 @@
   12         assert_equal(wallet0.gettransaction(descendant_tx_id)['details'][0]['abandoned'], True)
   13 
   14     def test_reorg_handling_during_unclean_shutdown(self):
   15+        # FIXME: skip test during CI run for now.
   16+        if os.environ.get('TESTS_CI_RUN'):
   17+            self.log.info("Skipping wallet reorg handling during shutdown test")
   18+            return
   19+
   20+
   21         self.log.info("Test that wallet doesn't crash due to a duplicate block disconnection event after an unclean shutdown")
   22         node = self.nodes[0]
   23         # Receive coinbase reward on a new wallet
   24Index: test/functional/test_runner.py
   25IDEA additional info:
   26Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
   27<+>UTF-8
   28===================================================================
   29diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
   30--- a/test/functional/test_runner.py	(revision 8d5a11f34157934d9aecf8d5535ec3c17b13fcf3)
   31+++ b/test/functional/test_runner.py	(date 1747318824956)
   32@@ -401,6 +401,7 @@
   33 
   34     args, unknown_args = parser.parse_known_args()
   35     fail_on_warn = args.ci
   36+    os.environ['TESTS_CI_RUN'] = args.ci
   37     if not args.ansi:
   38         global DEFAULT, BOLD, GREEN, RED
   39         DEFAULT = ("", "")
   

8. 
   mzumsande commented at 2:27 pm on May 15, 2025: contributor

   utACK fa981b90f53101bff2eda606d9479233e71736b5
9. 
   maflcko commented at 2:38 pm on May 15, 2025: member

   What if instead of excluding the entire test file, we only exclude the specific failing test case?

   Your diff would exclude the test case for all CI runs (even CI runs not using valgrind). I think longer term it would be better to just fix it.

10. 
    furszy commented at 3:06 pm on May 15, 2025: member

    What if instead of excluding the entire test file, we only exclude the specific failing test case?

    Your diff would exclude the test case for all CI runs (even CI runs not using valgrind).

    That would be easy to fix by just providing another environment variable for Valgrind runs. But np, it was just an idea to keep the test running while the issue is being investigated.

    I think longer term it would be better to just fix it.

    Hard to disagree.

11. fanquake merged this on May 15, 2025
12. fanquake closed this on May 15, 2025

    ---

13. maflcko deleted the branch on May 15, 2025

Contributors
maflcko DrahtBot fanquake furszy mzumsande

Labels
Tests