ci: Exclude failing wallet_reorgsrestore.py from valgrind task for now #32507

Fixes #32493

For some reason terminate or kill do not work inside the CI system under valgrind.

So disable the test for now, until a solution is found.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32507.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

ACK fa981b90f53101bff2eda606d9479233e71736b5

What if instead of excluding the entire test file, we only exclude the specific failing test case?

diff --git a/test/functional/wallet_reorgsrestore.py b/test/functional/wallet_reorgsrestore.py
--- a/test/functional/wallet_reorgsrestore.py	(revision 8d5a11f34157934d9aecf8d5535ec3c17b13fcf3)
+++ b/test/functional/wallet_reorgsrestore.py	(date 1747319065527)
@@ -14,6 +14,7 @@
 """
 
 from decimal import Decimal
+import os
 import shutil
 
 from test_framework.test_framework import BitcoinTestFramework
@@ -90,6 +91,12 @@
         assert_equal(wallet0.gettransaction(descendant_tx_id)['details'][0]['abandoned'], True)
 
     def test_reorg_handling_during_unclean_shutdown(self):
+        # FIXME: skip test during CI run for now.
+        if os.environ.get('TESTS_CI_RUN'):
+            self.log.info("Skipping wallet reorg handling during shutdown test")
+            return
+
+
         self.log.info("Test that wallet doesn't crash due to a duplicate block disconnection event after an unclean shutdown")
         node = self.nodes[0]
         # Receive coinbase reward on a new wallet
Index: test/functional/test_runner.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
--- a/test/functional/test_runner.py	(revision 8d5a11f34157934d9aecf8d5535ec3c17b13fcf3)
+++ b/test/functional/test_runner.py	(date 1747318824956)
@@ -401,6 +401,7 @@
 
     args, unknown_args = parser.parse_known_args()
     fail_on_warn = args.ci
+    os.environ['TESTS_CI_RUN'] = args.ci
     if not args.ansi:
         global DEFAULT, BOLD, GREEN, RED
         DEFAULT = ("", "")

utACK fa981b90f53101bff2eda606d9479233e71736b5

What if instead of excluding the entire test file, we only exclude the specific failing test case?

Your diff would exclude the test case for all CI runs (even CI runs not using valgrind). I think longer term it would be better to just fix it.

What if instead of excluding the entire test file, we only exclude the specific failing test case?

Your diff would exclude the test case for all CI runs (even CI runs not using valgrind).

That would be easy to fix by just providing another environment variable for Valgrind runs. But np, it was just an idea to keep the test running while the issue is being investigated.

I think longer term it would be better to just fix it.

Hard to disagree.