scripted-diff: Remove unused leading newline in RPC docs #32514

1. 
   maflcko commented at 1:55 pm on May 15, 2025: member

   It is harmless, but newlines in the beginning read a bit odd (“nReturns”). So just require them to not be present.

   The diff is large, but a trivial scripted-diff.

2. scripted-diff: Remove unused leading newline in RPC docs

   -BEGIN VERIFY SCRIPT-
    perl -0777 -pi -e 's/RPCHelpMan{\s*("[^"]+"),\s*"\\n/RPCHelpMan{\n        \1,\n        "/g' $( git grep -l 'RPCHelpMan{' )
   -END VERIFY SCRIPT-

   fa414eda08
3. 
   DrahtBot commented at 1:55 pm on May 15, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32514.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake, w0xlt

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30886 (rpc: Add support to populate PSBT input utxos via rpc by instagibbs)
   • #29415 (Broadcast own transactions only via short-lived Tor or I2P connections by vasild)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot renamed this:
   scripted-diff: Remove unused leading newline in RPC docs
   scripted-diff: Remove unused leading newline in RPC docs
   on May 15, 2025
5. DrahtBot added the label Refactoring on May 15, 2025
6. maflcko force-pushed on May 15, 2025
7. rpc: Reject beginning newline in RPC docs

   It is harmless, but a bit confusing and not needed for new code.
   
   Also, update the remaining instances that were not found by the
   scripted-diff.

   fae840e94b
8. 
   fanquake commented at 2:37 pm on May 15, 2025: member

   0 Run rpc with args ['/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64-apple-darwin23.6.0/bin/fuzz', PosixPath('/
   1
   2Assertion failed: (error_msg.find("trigger_internal_bug") != std::string::npos), function rpc_fuzz_target, file rpc.cpp, line 389.
   3Error processing input "/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets/fuzz_corpora/rpc/9cfc6f75197c087f55eb7ea406ef812047989f2b"
   4
   5⚠️ Failure generated from target with exit code 1: ['/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64-apple-darwin23.6.0/bin/fuzz', PosixPath('/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets/fuzz_corpora/rpc')]
   

9. maflcko force-pushed on May 15, 2025
10. maflcko force-pushed on May 15, 2025
11. 
    fanquake commented at 10:58 am on May 16, 2025: member

    Concept ACK - did you want to fix any more of the [Grammar] here?
12. doc: Fix minor typos in rpc help fa1f10a49e
13. maflcko force-pushed on May 16, 2025
14. DrahtBot added the label CI failed on May 16, 2025
15. DrahtBot removed the label CI failed on May 16, 2025
16. fanquake approved
17. 
    fanquake commented at 5:02 pm on May 16, 2025: member

    ACK fa1f10a49e7c4f6377fbc7ae2f1520b38c86e5fa
18. 
    w0xlt commented at 10:23 pm on May 16, 2025: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/32514/commits/fa1f10a49e7c4f6377fbc7ae2f1520b38c86e5fa
19. fanquake merged this on May 17, 2025
20. fanquake closed this on May 17, 2025

    ---

21. maflcko deleted the branch on May 19, 2025

Contributors
maflcko DrahtBot fanquake w0xlt

Labels
Refactoring