It is harmless, but newlines in the beginning read a bit odd ("nReturns"). So just require them to not be present.
The diff is large, but a trivial scripted-diff.
scripted-diff: Remove unused leading newline in RPC docs #32514
pull maflcko wants to merge 3 commits into bitcoin:master from maflcko:2505-rpc-newline changing 21 files +354 −241-
maflcko commented at 1:55 PM on May 15, 2025: member
-
fa414eda08
scripted-diff: Remove unused leading newline in RPC docs
-BEGIN VERIFY SCRIPT- perl -0777 -pi -e 's/RPCHelpMan{\s*("[^"]+"),\s*"\\n/RPCHelpMan{\n \1,\n "/g' $( git grep -l 'RPCHelpMan{' ) -END VERIFY SCRIPT- -
DrahtBot commented at 1:55 PM on May 15, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32514.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #30886 (rpc: Add support to populate PSBT input utxos via rpc by instagibbs)
- #29415 (Broadcast own transactions only via short-lived Tor or I2P connections by vasild)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot renamed this:
scripted-diff: Remove unused leading newline in RPC docs
scripted-diff: Remove unused leading newline in RPC docs
on May 15, 2025 - DrahtBot added the label Refactoring on May 15, 2025
- maflcko force-pushed on May 15, 2025
-
fae840e94b
rpc: Reject beginning newline in RPC docs
It is harmless, but a bit confusing and not needed for new code. Also, update the remaining instances that were not found by the scripted-diff.
-
fanquake commented at 2:37 PM on May 15, 2025: member
Run rpc with args ['/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64-apple-darwin23.6.0/bin/fuzz', PosixPath('/ Assertion failed: (error_msg.find("trigger_internal_bug") != std::string::npos), function rpc_fuzz_target, file rpc.cpp, line 389. Error processing input "/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets/fuzz_corpora/rpc/9cfc6f75197c087f55eb7ea406ef812047989f2b" ⚠️ Failure generated from target with exit code 1: ['/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64-apple-darwin23.6.0/bin/fuzz', PosixPath('/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets/fuzz_corpora/rpc')] - maflcko force-pushed on May 15, 2025
- maflcko force-pushed on May 15, 2025
-
fanquake commented at 10:58 AM on May 16, 2025: member
Concept ACK - did you want to fix any more of the [Grammar] here?
-
doc: Fix minor typos in rpc help fa1f10a49e
- maflcko force-pushed on May 16, 2025
- DrahtBot added the label CI failed on May 16, 2025
- DrahtBot removed the label CI failed on May 16, 2025
- fanquake approved
-
fanquake commented at 5:02 PM on May 16, 2025: member
ACK fa1f10a49e7c4f6377fbc7ae2f1520b38c86e5fa
-
w0xlt commented at 10:23 PM on May 16, 2025: contributor
- fanquake merged this on May 17, 2025
- fanquake closed this on May 17, 2025
- maflcko deleted the branch on May 19, 2025
Labels