The fork() isn’t needed and in fact makes the forked process not react to signals (like kill or terminate), so just avoid it and run the valgrind process directly in the CI task.
Can be tested with something like:
env -i HOME="$HOME" PATH="$PATH" USER="$USER" MAKEJOBS="-j$(nproc)" FILE_ENV="./ci/test/00_setup_env_native_valgrind.sh" ./ci/test_run_all.sh
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32519.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | fanquake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
If someone wants to quickly test this outside the CI system a minimal reproducer would be:
0───────┬────────────────────────────────────────────────────────────────────────
1 │ File: /tmp/a.py
2───────┼────────────────────────────────────────────────────────────────────────
3 1 │ import subprocess
4 2 │ import time
5 3 │
6 4 │ process = subprocess.Popen(["bash", "/tmp/a.sh"])
7 5 │ print("Wait for the first print to happen ...")
8 6 │ time.sleep(0.1)
9 7 │ process.kill()
10 8 │ print(f"Process ended with {process.wait()}. Should not print more!")
11───────┴────────────────────────────────────────────────────────────────────────
12───────┬────────────────────────────────────────────────────────────────────────
13 │ File: /tmp/a.sh
14───────┼────────────────────────────────────────────────────────────────────────
15 1 │ exec bash -c 'echo hi1 && sleep 1 && echo hi2 && false'
16───────┴────────────────────────────────────────────────────────────────────────
Command: python3 /tmp/a.py
