ci: Enable feature_init and wallet_reorgsrestore in valgrind task #32519

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2505-ci-valgrind changing 2 files +3 −6
  1. maflcko commented at 4:42 PM on May 15, 2025: member

    The fork() isn't needed and in fact makes the forked process not react to signals (like kill or terminate), so just avoid it and run the valgrind process directly in the CI task.

    Can be tested with something like:

    env -i HOME="$HOME" PATH="$PATH" USER="$USER" MAKEJOBS="-j$(nproc)" FILE_ENV="./ci/test/00_setup_env_native_valgrind.sh" ./ci/test_run_all.sh

  2. ci: Enable feature_init and wallet_reorgsrestore in valgrind task fa2be605fe
  3. DrahtBot commented at 4:42 PM on May 15, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32519.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. DrahtBot added the label Tests on May 15, 2025
  5. maflcko commented at 8:24 AM on May 16, 2025: member

    If someone wants to quickly test this outside the CI system a minimal reproducer would be:

    ───────┬────────────────────────────────────────────────────────────────────────
           │ File: /tmp/a.py
    ───────┼────────────────────────────────────────────────────────────────────────
       1   │ import subprocess
       2   │ import time
       3   │ 
       4   │ process = subprocess.Popen(["bash", "/tmp/a.sh"])
       5   │ print("Wait for the first print to happen ...")
       6   │ time.sleep(0.1)
       7   │ process.kill()
       8   │ print(f"Process ended with {process.wait()}. Should not print more!")
    ───────┴────────────────────────────────────────────────────────────────────────
    ───────┬────────────────────────────────────────────────────────────────────────
           │ File: /tmp/a.sh
    ───────┼────────────────────────────────────────────────────────────────────────
       1   │ exec bash -c 'echo hi1 && sleep 1 && echo hi2 && false'
    ───────┴────────────────────────────────────────────────────────────────────────
    

    Command: python3 /tmp/a.py

  6. fanquake approved
  7. fanquake commented at 5:00 PM on May 16, 2025: member

    ACK fa2be605fee42c1286de2ddefbec976dde2c35ba - x86_64, aarch64

  8. fanquake merged this on May 16, 2025
  9. fanquake closed this on May 16, 2025

  10. maflcko deleted the branch on May 16, 2025
  11. stickies-v referenced this in commit 772a33e052 on May 23, 2025
  12. sedited referenced this in commit cb3cd9b8b9 on May 29, 2025
  13. yuvicc referenced this in commit 069643f094 on Jul 6, 2025
  14. bug-castercv502 referenced this in commit 2858098810 on Sep 28, 2025
  15. Kino1994 referenced this in commit 1e1f3a38b1 on Jun 28, 2026
  16. BigcoinBGC referenced this in commit c2fd43f0a6 on Jun 30, 2026
  17. bitcoin locked this on Jul 30, 2026
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-11 10:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me