Update leveldb subtree to latest upstream #32534

fanquake commented at 3:15 PM on May 16, 2025: member

Pulls in

https://github.com/bitcoin-core/leveldb-subtree/pull/51

Remove the related warning suppression.

Squashed 'src/leveldb/' changes from 4188247086..113db4962b

113db4962b Merge bitcoin-core/leveldb-subtree#51: refactor: add missing overrides
9defe8494a refactor: add missing overrides

git-subtree-dir: src/leveldb
git-subtree-split: 113db4962b8be416c17ad2b4bdcc5514c51d7181

e2c84b896f

Update leveldb subtree to latest upstream 0769c8fc99

build: remove Wsuggest-override suppression from leveldb build 7015052eba

DrahtBot commented at 3:15 PM on May 16, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32534.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	l0rinc, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#31507 (build: Use clang-cl to build on Windows natively by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

l0rinc commented at 3:20 PM on May 16, 2025: contributor

utACK 7015052eba23368539dcd1a9b4217ce1cacd2999

For the record, there are other LevelDB changes that could use some reviews: https://github.com/bitcoin-core/leveldb-subtree/pulls

fanquake commented at 5:07 PM on May 16, 2025: member

Guix Build

a12f2290f4e5267f2ba9ad9da0d95e7990ea3e5772d7658a133d607a25afe7b4  guix-build-7015052eba23/output/aarch64-linux-gnu/SHA256SUMS.part
6232c5017a17753b33c62f32def946a72f70ce63b76b55dc9a8fa8c8e75229fe  guix-build-7015052eba23/output/aarch64-linux-gnu/bitcoin-7015052eba23-aarch64-linux-gnu-debug.tar.gz
c702cf46c5c463ccd08ec97f3858cf1a1ce612e0c92836f6dedc94d1f6ad16f3  guix-build-7015052eba23/output/aarch64-linux-gnu/bitcoin-7015052eba23-aarch64-linux-gnu.tar.gz
a0e2e6f5198c435c100c12d0dc7084a154d2d4b26dae6cbcc5e41a67228859cb  guix-build-7015052eba23/output/arm-linux-gnueabihf/SHA256SUMS.part
201368fa6020d2230375f872ba0d85ede0e679d8b4a3f51a357d469504e512c1  guix-build-7015052eba23/output/arm-linux-gnueabihf/bitcoin-7015052eba23-arm-linux-gnueabihf-debug.tar.gz
c9e1c1bcc2869cd157c8673e561bf5a5d51ec493132819e3b93d562ce3b6fcd1  guix-build-7015052eba23/output/arm-linux-gnueabihf/bitcoin-7015052eba23-arm-linux-gnueabihf.tar.gz
9390475fa064672eabbab5e0e514c4c46a859458074c2d8caac87ed43e93db18  guix-build-7015052eba23/output/arm64-apple-darwin/SHA256SUMS.part
b22b26e3db1e9eb589609ec47e7fa6a546f1c3616a484619c8e3604cd927fa18  guix-build-7015052eba23/output/arm64-apple-darwin/bitcoin-7015052eba23-arm64-apple-darwin-codesigning.tar.gz
17babf69caa4c37558359ab1d5de06cd293674a7a03cf3aefd950a5bdc6be4a2  guix-build-7015052eba23/output/arm64-apple-darwin/bitcoin-7015052eba23-arm64-apple-darwin-unsigned.tar.gz
d9a279d7089e57b26d9535dabb92be68be1f097f1d7feedf1b8595977f75a9bd  guix-build-7015052eba23/output/arm64-apple-darwin/bitcoin-7015052eba23-arm64-apple-darwin-unsigned.zip
f04ac246fc18745a3666beae943356be73c80d373e4c321a4981ef3aac6a7349  guix-build-7015052eba23/output/dist-archive/bitcoin-7015052eba23.tar.gz
3eeed0b25e7538a73ac57568d1c0309c116774a06ca103a1b05c15c3a5ce6976  guix-build-7015052eba23/output/powerpc64-linux-gnu/SHA256SUMS.part
a3cfec5dd137d30f49c1b125acbf1fcb5f8c882f41c8875658a7339bb964eac2  guix-build-7015052eba23/output/powerpc64-linux-gnu/bitcoin-7015052eba23-powerpc64-linux-gnu-debug.tar.gz
50b37b3fa183247c706e13cb6fabf7e0d648e7ccf1b491fc2f9ec3b4e3357e90  guix-build-7015052eba23/output/powerpc64-linux-gnu/bitcoin-7015052eba23-powerpc64-linux-gnu.tar.gz
4ae3f8aaaf3e57a1249323babb12afd0f97e4ba5e4dd86359d6f7ddabeecb3c2  guix-build-7015052eba23/output/riscv64-linux-gnu/SHA256SUMS.part
b714e51c9b593adc32a35c3dcaac66798c50124d0524f4b07d04244a58bc1bbb  guix-build-7015052eba23/output/riscv64-linux-gnu/bitcoin-7015052eba23-riscv64-linux-gnu-debug.tar.gz
6a2beb9f94debf061b334c5116be55afcd636b62ef2cf27f97eedf4f6baea435  guix-build-7015052eba23/output/riscv64-linux-gnu/bitcoin-7015052eba23-riscv64-linux-gnu.tar.gz
64303cf64172efe2029c1891f83a72832396a40535f1060bec9d22679c40ae6a  guix-build-7015052eba23/output/x86_64-apple-darwin/SHA256SUMS.part
88f64cac07974c831bf2fe54302edbcf1f1c8a39cfbcc5e319ef67150a87f41b  guix-build-7015052eba23/output/x86_64-apple-darwin/bitcoin-7015052eba23-x86_64-apple-darwin-codesigning.tar.gz
332b1b0bb76419a0ea4ed1666e6559e8241731759efb68095b7307fe9f737983  guix-build-7015052eba23/output/x86_64-apple-darwin/bitcoin-7015052eba23-x86_64-apple-darwin-unsigned.tar.gz
c5a912893d85c8b6def93a87107d2460535004140037a08c2822360ad3470ade  guix-build-7015052eba23/output/x86_64-apple-darwin/bitcoin-7015052eba23-x86_64-apple-darwin-unsigned.zip
a7ee2e0e43d2c484d18dd4301283b5eb3cdc2aa52a7570ef3986370976c47bbd  guix-build-7015052eba23/output/x86_64-linux-gnu/SHA256SUMS.part
bbbaf34a936bbadf482ffbb7f911c8e696516f63431848d3d64d5e7ff84deb30  guix-build-7015052eba23/output/x86_64-linux-gnu/bitcoin-7015052eba23-x86_64-linux-gnu-debug.tar.gz
54611e97f8f865a7f75608177e499ce33345e240d123dda994156ee568d2ffe9  guix-build-7015052eba23/output/x86_64-linux-gnu/bitcoin-7015052eba23-x86_64-linux-gnu.tar.gz
bab8079fefb8bc0e30e3d28fa252a5afc5baacc3ee9f04523ed8f95f176e4c7e  guix-build-7015052eba23/output/x86_64-w64-mingw32/SHA256SUMS.part
1f2b18b7a390eec8320f4b4a379203fc50092984787deb08b9d1cdf4ecf2914f  guix-build-7015052eba23/output/x86_64-w64-mingw32/bitcoin-7015052eba23-win64-codesigning.tar.gz
b87e2ea92a90098e6c6eeef286c789b4cf5f6d6017a41eb70ce02db166bf9325  guix-build-7015052eba23/output/x86_64-w64-mingw32/bitcoin-7015052eba23-win64-debug.zip
70db0ddf211b2e6bebd70f15f68873c2fca78bd6614bd736676ea103965302ac  guix-build-7015052eba23/output/x86_64-w64-mingw32/bitcoin-7015052eba23-win64-setup-unsigned.exe
8b0e45314539e5c36aece6e199470f0156e39c8eadd847ef0e325a5b23ca8ab3  guix-build-7015052eba23/output/x86_64-w64-mingw32/bitcoin-7015052eba23-win64-unsigned.zip

hebasto commented at 8:13 AM on May 17, 2025: member

My Guix build:

aarch64
a12f2290f4e5267f2ba9ad9da0d95e7990ea3e5772d7658a133d607a25afe7b4  guix-build-7015052eba23/output/aarch64-linux-gnu/SHA256SUMS.part
6232c5017a17753b33c62f32def946a72f70ce63b76b55dc9a8fa8c8e75229fe  guix-build-7015052eba23/output/aarch64-linux-gnu/bitcoin-7015052eba23-aarch64-linux-gnu-debug.tar.gz
c702cf46c5c463ccd08ec97f3858cf1a1ce612e0c92836f6dedc94d1f6ad16f3  guix-build-7015052eba23/output/aarch64-linux-gnu/bitcoin-7015052eba23-aarch64-linux-gnu.tar.gz
a0e2e6f5198c435c100c12d0dc7084a154d2d4b26dae6cbcc5e41a67228859cb  guix-build-7015052eba23/output/arm-linux-gnueabihf/SHA256SUMS.part
201368fa6020d2230375f872ba0d85ede0e679d8b4a3f51a357d469504e512c1  guix-build-7015052eba23/output/arm-linux-gnueabihf/bitcoin-7015052eba23-arm-linux-gnueabihf-debug.tar.gz
c9e1c1bcc2869cd157c8673e561bf5a5d51ec493132819e3b93d562ce3b6fcd1  guix-build-7015052eba23/output/arm-linux-gnueabihf/bitcoin-7015052eba23-arm-linux-gnueabihf.tar.gz
9390475fa064672eabbab5e0e514c4c46a859458074c2d8caac87ed43e93db18  guix-build-7015052eba23/output/arm64-apple-darwin/SHA256SUMS.part
b22b26e3db1e9eb589609ec47e7fa6a546f1c3616a484619c8e3604cd927fa18  guix-build-7015052eba23/output/arm64-apple-darwin/bitcoin-7015052eba23-arm64-apple-darwin-codesigning.tar.gz
17babf69caa4c37558359ab1d5de06cd293674a7a03cf3aefd950a5bdc6be4a2  guix-build-7015052eba23/output/arm64-apple-darwin/bitcoin-7015052eba23-arm64-apple-darwin-unsigned.tar.gz
d9a279d7089e57b26d9535dabb92be68be1f097f1d7feedf1b8595977f75a9bd  guix-build-7015052eba23/output/arm64-apple-darwin/bitcoin-7015052eba23-arm64-apple-darwin-unsigned.zip
f04ac246fc18745a3666beae943356be73c80d373e4c321a4981ef3aac6a7349  guix-build-7015052eba23/output/dist-archive/bitcoin-7015052eba23.tar.gz
3eeed0b25e7538a73ac57568d1c0309c116774a06ca103a1b05c15c3a5ce6976  guix-build-7015052eba23/output/powerpc64-linux-gnu/SHA256SUMS.part
a3cfec5dd137d30f49c1b125acbf1fcb5f8c882f41c8875658a7339bb964eac2  guix-build-7015052eba23/output/powerpc64-linux-gnu/bitcoin-7015052eba23-powerpc64-linux-gnu-debug.tar.gz
50b37b3fa183247c706e13cb6fabf7e0d648e7ccf1b491fc2f9ec3b4e3357e90  guix-build-7015052eba23/output/powerpc64-linux-gnu/bitcoin-7015052eba23-powerpc64-linux-gnu.tar.gz
4ae3f8aaaf3e57a1249323babb12afd0f97e4ba5e4dd86359d6f7ddabeecb3c2  guix-build-7015052eba23/output/riscv64-linux-gnu/SHA256SUMS.part
b714e51c9b593adc32a35c3dcaac66798c50124d0524f4b07d04244a58bc1bbb  guix-build-7015052eba23/output/riscv64-linux-gnu/bitcoin-7015052eba23-riscv64-linux-gnu-debug.tar.gz
6a2beb9f94debf061b334c5116be55afcd636b62ef2cf27f97eedf4f6baea435  guix-build-7015052eba23/output/riscv64-linux-gnu/bitcoin-7015052eba23-riscv64-linux-gnu.tar.gz
64303cf64172efe2029c1891f83a72832396a40535f1060bec9d22679c40ae6a  guix-build-7015052eba23/output/x86_64-apple-darwin/SHA256SUMS.part
88f64cac07974c831bf2fe54302edbcf1f1c8a39cfbcc5e319ef67150a87f41b  guix-build-7015052eba23/output/x86_64-apple-darwin/bitcoin-7015052eba23-x86_64-apple-darwin-codesigning.tar.gz
332b1b0bb76419a0ea4ed1666e6559e8241731759efb68095b7307fe9f737983  guix-build-7015052eba23/output/x86_64-apple-darwin/bitcoin-7015052eba23-x86_64-apple-darwin-unsigned.tar.gz
c5a912893d85c8b6def93a87107d2460535004140037a08c2822360ad3470ade  guix-build-7015052eba23/output/x86_64-apple-darwin/bitcoin-7015052eba23-x86_64-apple-darwin-unsigned.zip
a7ee2e0e43d2c484d18dd4301283b5eb3cdc2aa52a7570ef3986370976c47bbd  guix-build-7015052eba23/output/x86_64-linux-gnu/SHA256SUMS.part
bbbaf34a936bbadf482ffbb7f911c8e696516f63431848d3d64d5e7ff84deb30  guix-build-7015052eba23/output/x86_64-linux-gnu/bitcoin-7015052eba23-x86_64-linux-gnu-debug.tar.gz
54611e97f8f865a7f75608177e499ce33345e240d123dda994156ee568d2ffe9  guix-build-7015052eba23/output/x86_64-linux-gnu/bitcoin-7015052eba23-x86_64-linux-gnu.tar.gz
bab8079fefb8bc0e30e3d28fa252a5afc5baacc3ee9f04523ed8f95f176e4c7e  guix-build-7015052eba23/output/x86_64-w64-mingw32/SHA256SUMS.part
1f2b18b7a390eec8320f4b4a379203fc50092984787deb08b9d1cdf4ecf2914f  guix-build-7015052eba23/output/x86_64-w64-mingw32/bitcoin-7015052eba23-win64-codesigning.tar.gz
b87e2ea92a90098e6c6eeef286c789b4cf5f6d6017a41eb70ce02db166bf9325  guix-build-7015052eba23/output/x86_64-w64-mingw32/bitcoin-7015052eba23-win64-debug.zip
70db0ddf211b2e6bebd70f15f68873c2fca78bd6614bd736676ea103965302ac  guix-build-7015052eba23/output/x86_64-w64-mingw32/bitcoin-7015052eba23-win64-setup-unsigned.exe
8b0e45314539e5c36aece6e199470f0156e39c8eadd847ef0e325a5b23ca8ab3  guix-build-7015052eba23/output/x86_64-w64-mingw32/bitcoin-7015052eba23-win64-unsigned.zip

hebasto approved

hebasto commented at 8:40 AM on May 17, 2025: member

ACK 7015052eba23368539dcd1a9b4217ce1cacd2999, I've updated the leveldb subtree locally and got zero diff with this branch.

hebasto merged this on May 17, 2025

hebasto closed this on May 17, 2025

fanquake deleted the branch on May 17, 2025