ci: Move DEBUG=1 to centos task #32560

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2505-ci-debug changing 2 files +4 −4
  1. maflcko commented at 10:27 am on May 19, 2025: member

    The glibcxx debug mode has many bugs in prior gcc releases:

    Instead of working around all of them, just use the existing ci_native_centos task with gcc-14 to have it enabled. This also follows the logic of other sanitizers (tsan, asan, ubsan, msan, valgrind, …) to generally prefer the latest version of the sanitizer for the latests features and bugfixes.

    Fixes #32524.

    Also, while touching the ci_native_previous_releases, increase g0 to g2, so that it is easier for developers to use gdb inside the CI without having to re-compile

  2. DrahtBot commented at 10:27 am on May 19, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32560.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Tests on May 19, 2025
  4. hebasto commented at 10:53 am on May 19, 2025: member
    Changes look correct. Waiting for CI.
  5. ci: Move DEBUG=1 to centos task fa58d6cdab
  6. maflcko force-pushed on May 19, 2025
  7. hebasto approved
  8. hebasto commented at 2:09 pm on May 19, 2025: member
    ACK fa58d6cdab000df288501db4a71487804b08ba4b.
  9. in ci/test/00_setup_env_native_previous_releases.sh:23 in fa58d6cdab
    19@@ -20,8 +20,8 @@ export BITCOIN_CONFIG="\
    20  -DWITH_ZMQ=ON -DBUILD_GUI=ON -DREDUCE_EXPORTS=ON \
    21  -DCMAKE_BUILD_TYPE=Debug \
    22  -DCMAKE_C_FLAGS='-funsigned-char' \
    23- -DCMAKE_C_FLAGS_DEBUG='-g0 -O2' \
    24+ -DCMAKE_C_FLAGS_DEBUG='-g2 -O2' \
    


    fanquake commented at 2:16 pm on May 19, 2025:
    Any reason to set this to -g2, rather than -g3 (the default for our Debug build type)?.

    maflcko commented at 3:10 pm on May 19, 2025:

    No reason. I’d say anything is fine here.

    Initially this was set in 14788fbadac3aa352eb51da81ecdfa01208ca33c, but we have a larger cache now.

  10. maflcko added this to the milestone 30.0 on May 20, 2025
  11. fanquake approved
  12. fanquake commented at 8:29 am on May 20, 2025: member
    ACK fa58d6cdab000df288501db4a71487804b08ba4b
  13. fanquake merged this on May 20, 2025
  14. fanquake closed this on May 20, 2025

  15. maflcko deleted the branch on May 20, 2025


maflcko DrahtBot hebasto fanquake

Labels
Tests

Milestone
30.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-25 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me