ci: Move DEBUG=1 to centos task #32560

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2505-ci-debug changing 2 files +4 −4
  1. maflcko commented at 10:27 AM on May 19, 2025: member

    The glibcxx debug mode has many bugs in prior gcc releases:

    Instead of working around all of them, just use the existing ci_native_centos task with gcc-14 to have it enabled. This also follows the logic of other sanitizers (tsan, asan, ubsan, msan, valgrind, ...) to generally prefer the latest version of the sanitizer for the latests features and bugfixes.

    Fixes #32524.

    Also, while touching the ci_native_previous_releases, increase g0 to g2, so that it is easier for developers to use gdb inside the CI without having to re-compile

  2. DrahtBot commented at 10:27 AM on May 19, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32560.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. DrahtBot added the label Tests on May 19, 2025
  4. hebasto commented at 10:53 AM on May 19, 2025: member

    Changes look correct. Waiting for CI.

  5. ci: Move DEBUG=1 to centos task fa58d6cdab
  6. maflcko force-pushed on May 19, 2025
  7. hebasto approved
  8. hebasto commented at 2:09 PM on May 19, 2025: member

    ACK fa58d6cdab000df288501db4a71487804b08ba4b.

  9. in ci/test/00_setup_env_native_previous_releases.sh:23 in fa58d6cdab
      19 | @@ -20,8 +20,8 @@ export BITCOIN_CONFIG="\
      20 |   -DWITH_ZMQ=ON -DBUILD_GUI=ON -DREDUCE_EXPORTS=ON \
      21 |   -DCMAKE_BUILD_TYPE=Debug \
      22 |   -DCMAKE_C_FLAGS='-funsigned-char' \
      23 | - -DCMAKE_C_FLAGS_DEBUG='-g0 -O2' \
      24 | + -DCMAKE_C_FLAGS_DEBUG='-g2 -O2' \
    


    fanquake commented at 2:16 PM on May 19, 2025:

    Any reason to set this to -g2, rather than -g3 (the default for our Debug build type)?.


    maflcko commented at 3:10 PM on May 19, 2025:

    No reason. I'd say anything is fine here.

    Initially this was set in 14788fbadac3aa352eb51da81ecdfa01208ca33c, but we have a larger cache now.

  10. maflcko added this to the milestone 30.0 on May 20, 2025
  11. fanquake approved
  12. fanquake commented at 8:29 AM on May 20, 2025: member

    ACK fa58d6cdab000df288501db4a71487804b08ba4b

  13. fanquake merged this on May 20, 2025
  14. fanquake closed this on May 20, 2025

  15. maflcko deleted the branch on May 20, 2025
  16. sedited referenced this in commit cb3cd9b8b9 on May 29, 2025
  17. yuvicc referenced this in commit 069643f094 on Jul 6, 2025
  18. bug-castercv502 referenced this in commit 2858098810 on Sep 28, 2025
  19. dathonohm referenced this in commit fd3b0a899b on Dec 23, 2025
  20. dathonohm referenced this in commit 4326a55e4b on Dec 23, 2025
  21. dathonohm referenced this in commit 110b9830b9 on Jan 12, 2026
  22. Retropex referenced this in commit 99974147e6 on Feb 11, 2026
  23. dathonohm referenced this in commit de3d0e438b on Feb 11, 2026
  24. v72t referenced this in commit 754b8e9f80 on Feb 14, 2026
  25. v72t referenced this in commit 43465ff5bc on Mar 4, 2026
  26. Kino1994 referenced this in commit 166ef04750 on Jun 28, 2026
  27. BigcoinBGC referenced this in commit 5bea0972f7 on Jun 30, 2026
  28. bitcoin locked this on Jul 30, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-04 00:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me