test: `tool_wallet.py` references no-longer used CI #32576

issue fanquake opened this issue on May 21, 2025

fanquake commented at 10:05 AM on May 21, 2025: member

We no longer use Appveyor, so any code that existed to support it, should be dropped:

https://github.com/bitcoin/bitcoin/blob/54e406a3055ad0454a576f14b51def34ab8e9209/test/functional/tool_wallet.py#L160

https://github.com/bitcoin/bitcoin/blob/54e406a3055ad0454a576f14b51def34ab8e9209/test/functional/tool_wallet.py#L171
fanquake added the label Tests on May 21, 2025
jonatack commented at 1:49 PM on May 21, 2025: member

#28116 addresses it. Can update it.
m3dwards commented at 3:42 PM on May 23, 2025: contributor

Removing '666' fails tests on windows: https://github.com/m3dwards/bitcoin/actions/runs/15213032706/job/42791654918

Suggest just changing comment to:

666 on Windows
jonatack commented at 6:28 PM on May 23, 2025: member

@m3dwards those comments can be dropped completely; see #28116, which I will update and open.
Mercy435 commented at 12:53 PM on June 8, 2025: none

Hi @jonatack, I noticed this issue (#32576) is still open and that your previous PR (#28116) was closed a while back. Are you still planning to work on it?

If not, I’d be happy to take it over and submit a small PR to remove the outdated Appveyor-related comments. Let me know — I can have a patch ready in a few days.
jonatack commented at 3:45 PM on June 8, 2025: member

Hi @Mercy435 -- yes, am updating #28116.
Mercy435 commented at 3:55 PM on June 8, 2025: none

Thanks for the quick update, @jonatack! Glad to hear you're on it and updating #28116. Please feel free to reach out if there’s any way I can help.
fanquake added the label Windows on Feb 17, 2026
fanquake commented at 10:48 AM on February 17, 2026: member

Suggest just changing comment to: 666 on Windows @m3dwards can you open a PR to address this?
maflcko added the label good first issue on Feb 17, 2026
fanquake removed the label good first issue on Feb 18, 2026
fanquake commented at 11:52 AM on February 18, 2026: member

Will close this, and we can finish up in #34609.
fanquake closed this on Feb 18, 2026

Contributors

Labels

Linked (view graph)

#34609 test: remove appveyor reference in comment