The per-host flag values now represent the mandatory flags that cannot be overridden by the environment. Additionally, these flags (-pipe and -std=xx) will no longer be passed into the CMake build.
Pulled out of #31920.
depends: hard-code necessary c(xx)flags rather than setting them per-host #32584
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends_hard_code_flags changing 7 files +16 −14-
fanquake commented at 9:33 am on May 22, 2025: member
-
0275825f7a
depends: hard-code necessary c(xx)flags rather than setting them per-host
The per-host flag values now represent the mandatory flags that cannot be overridden by the environment. Additionally, these flags (-pipe and -std=xx) will no longer be passed into the CMake build.
-
DrahtBot commented at 9:33 am on May 22, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32584.
Reviews
See the guideline for information on the review process.
Type Reviewers Concept ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
fanquake added the label DrahtBot Guix build requested on May 22, 2025
-
hebasto commented at 10:28 am on May 22, 2025: memberConcept ACK.
-
maflcko commented at 12:08 pm on May 22, 2025: member
The per-host flag values now represent the mandatory flags that cannot be overridden by the environment. Additionally, these flags (-pipe and -std=xx) will no longer be passed into the CMake build.
Would be nice to explain this with commands to test and observe the difference in behavior. This would make it easier to understand the goals and test them.
-
hebasto commented at 2:21 pm on May 22, 2025: member
My Guix build:
0aarch64 17a5858e3364998675e06a2bec330a6fb9f619613a9228a568b5c98cba873460f guix-build-0275825f7ace/output/aarch64-linux-gnu/SHA256SUMS.part 2a8b08f5f246ca97ae26bf9142355797f82d3f1e7eb2ffbc1b7d78f35c4c0cd4d guix-build-0275825f7ace/output/aarch64-linux-gnu/bitcoin-0275825f7ace-aarch64-linux-gnu-debug.tar.gz 392cbdec0549173a3e3a90ac81ad2dac98d9758a76efe12a6d205cc1265f9f701 guix-build-0275825f7ace/output/aarch64-linux-gnu/bitcoin-0275825f7ace-aarch64-linux-gnu.tar.gz 4c7915b68fdfa3fb68e78d6264f36ddca591204578d8f3d857c3d322a17522439 guix-build-0275825f7ace/output/arm-linux-gnueabihf/SHA256SUMS.part 555777a80adf1abf9e39cac043e5736279b67b67dc8dac2a3c37a19cb37e71e54 guix-build-0275825f7ace/output/arm-linux-gnueabihf/bitcoin-0275825f7ace-arm-linux-gnueabihf-debug.tar.gz 61ecff64fb689fdf879de55a5a702fdcf9e35617f012a40f989e1365304745ae3 guix-build-0275825f7ace/output/arm-linux-gnueabihf/bitcoin-0275825f7ace-arm-linux-gnueabihf.tar.gz 7644d8e2e1b5cd4316703c6fa78d65a3ea575a31e1f24938efbf02eaadaf1bbc4 guix-build-0275825f7ace/output/arm64-apple-darwin/SHA256SUMS.part 8e4fa5170eaf6b0dbc792f33bc163d8ba22b0a05c0bd1b1e225bc50ad48448720 guix-build-0275825f7ace/output/arm64-apple-darwin/bitcoin-0275825f7ace-arm64-apple-darwin-codesigning.tar.gz 99684c05d427446218e72f40340f65680f8e2b1a06496b7ab3f65181daf432a9b guix-build-0275825f7ace/output/arm64-apple-darwin/bitcoin-0275825f7ace-arm64-apple-darwin-unsigned.tar.gz 10a9b892fa30ef9e02c9066635bd7768a13c3971ec0035d13c0857a8c837af2170 guix-build-0275825f7ace/output/arm64-apple-darwin/bitcoin-0275825f7ace-arm64-apple-darwin-unsigned.zip 11b085ac19b1eac59497975bccbe4997b772a224c27c527376950590ce86b8ef82 guix-build-0275825f7ace/output/dist-archive/bitcoin-0275825f7ace.tar.gz 127da262d6ac77a64fc5c3a550c6b72dd9dd93a923cbf3045edc4696eb4e1af043 guix-build-0275825f7ace/output/powerpc64-linux-gnu/SHA256SUMS.part 135eef5b5c79b26f3f8ad3243637ca238b5e43f55f369375312ab186dc29213e7b guix-build-0275825f7ace/output/powerpc64-linux-gnu/bitcoin-0275825f7ace-powerpc64-linux-gnu-debug.tar.gz 143a5f90e01e28fa920954bc551594936d359f0009033172d218cb31bd6842138b guix-build-0275825f7ace/output/powerpc64-linux-gnu/bitcoin-0275825f7ace-powerpc64-linux-gnu.tar.gz 15ed6ce026a6ae7a22dfcdc7f9c8c2ab4df33f665562b65924633288fa9b19f7e8 guix-build-0275825f7ace/output/riscv64-linux-gnu/SHA256SUMS.part 16205569f39bc41d0b70206f08dbafae994afaedce32c2dd79972c9775dc916dd8 guix-build-0275825f7ace/output/riscv64-linux-gnu/bitcoin-0275825f7ace-riscv64-linux-gnu-debug.tar.gz 1790f23ce8f6498992b55069b5c8f616adfb9b5061bb301fee31f2e4ebc7912741 guix-build-0275825f7ace/output/riscv64-linux-gnu/bitcoin-0275825f7ace-riscv64-linux-gnu.tar.gz 184628de0d41b2a2fceddc115e66a54455cdd0eea61118c841ac9ba0dc789cf3c6 guix-build-0275825f7ace/output/x86_64-apple-darwin/SHA256SUMS.part 19e851467d91e4d0ccccd3a93e3b34a76eb1c7df22c5167014ee7273f9ea78b481 guix-build-0275825f7ace/output/x86_64-apple-darwin/bitcoin-0275825f7ace-x86_64-apple-darwin-codesigning.tar.gz 207e933ca4b5598f50d7c981f4c555965b383469c15a138c426c3151626de676b4 guix-build-0275825f7ace/output/x86_64-apple-darwin/bitcoin-0275825f7ace-x86_64-apple-darwin-unsigned.tar.gz 2103fe5fc86d56a1a88f5b50e2da2fad4c72449ae3f6922aa7366cd15e730f4b89 guix-build-0275825f7ace/output/x86_64-apple-darwin/bitcoin-0275825f7ace-x86_64-apple-darwin-unsigned.zip 2211de70c37658da525c7c24d9230ac56256c081446bd1db4adab6daa5bc4f44d6 guix-build-0275825f7ace/output/x86_64-linux-gnu/SHA256SUMS.part 23b9afb4e4991e07d33b221be4b3e8dbbafa97cd9ea32d86750d0badb507545ff0 guix-build-0275825f7ace/output/x86_64-linux-gnu/bitcoin-0275825f7ace-x86_64-linux-gnu-debug.tar.gz 24b52d43b67ff116532f7570ea370328f769058cb1b98e61bc4458ad9ea61816b6 guix-build-0275825f7ace/output/x86_64-linux-gnu/bitcoin-0275825f7ace-x86_64-linux-gnu.tar.gz 257a226edf53b81befd0f88897894dd379d5ff646d8e39e24d8d9cbadb349d2f71 guix-build-0275825f7ace/output/x86_64-w64-mingw32/SHA256SUMS.part 26eeb512d3fa02d381eb440b91eeb7c59498021181a6d59c7f4b6e2a7836e7b913 guix-build-0275825f7ace/output/x86_64-w64-mingw32/bitcoin-0275825f7ace-win64-codesigning.tar.gz 27f90557e9ec12797544e46ce487ea615c0034963e570e67ddace85fafdb654455 guix-build-0275825f7ace/output/x86_64-w64-mingw32/bitcoin-0275825f7ace-win64-debug.zip 28b5aef6dbcc804ede4750c0975b3936df16dc855f41b867044207893a09facc0e guix-build-0275825f7ace/output/x86_64-w64-mingw32/bitcoin-0275825f7ace-win64-setup-unsigned.exe 29ca9d189c66eb2b4f4f56f93272fd09ba2bf8d46dc68217782163020d2071c81e guix-build-0275825f7ace/output/x86_64-w64-mingw32/bitcoin-0275825f7ace-win64-unsigned.zip -
DrahtBot commented at 2:04 am on May 23, 2025: contributor
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]
File commit 35bf3f88398da0211cece0a29da4de001e34a4dd(master) commit 21d855af47ee4cbcd038c588529566779181fc32(pull/32584/merge) *-aarch64-linux-gnu-debug.tar.gz c35cf51a398c92df...a22608e4225637a7...*-aarch64-linux-gnu.tar.gz 82d0798dfae78051...2f2705212ffa1c69...*-arm-linux-gnueabihf-debug.tar.gz df45940210e7d3b8...34ac31537a9af3d6...*-arm-linux-gnueabihf.tar.gz f8999c6256936417...68c1e4ec2a247131...*-arm64-apple-darwin-codesigning.tar.gz e33513a263389b7c...81bf7cd522670770...*-arm64-apple-darwin-unsigned.tar.gz 7c5a453513ec0850...f47233df5c83e4cf...*-arm64-apple-darwin-unsigned.zip d57eb714e111132b...e3dfe76fc44c05c2...*-powerpc64-linux-gnu-debug.tar.gz 5467ae49d1d3c68c...a7456d49c6dd2915...*-powerpc64-linux-gnu.tar.gz 76f667e56592f732...398f77f8f5877965...*-riscv64-linux-gnu-debug.tar.gz 29c6f37babe24e24...433a3a360708e910...*-riscv64-linux-gnu.tar.gz 4ac255dfa3f295c6...750d33b88fd4db35...*-x86_64-apple-darwin-codesigning.tar.gz 1fab8a669d4b58c9...1ca27635a9338e0e...*-x86_64-apple-darwin-unsigned.tar.gz abbbc7b484711bc7...55a3db7ba7c8e60d...*-x86_64-apple-darwin-unsigned.zip d748d4548ea33f6c...df58b83819fa4ba3...*-x86_64-linux-gnu-debug.tar.gz 8fc1e04b90d920df...0f1bab24f73b0f1f...*-x86_64-linux-gnu.tar.gz 7831f9973e845882...bcf9e56695d9437a...*.tar.gz eaf62bd30c82aab0...2f988f8cbb8e698d...SHA256SUMS.part 9ca1bc71bda735df...f2b33615e84e95d3...guix_build.log 810be13f8c3ecc43...21055af7dd4549f6...guix_build.log.diff 716ad18d12ece0ad... -
DrahtBot removed the label DrahtBot Guix build requested on May 23, 2025
-
DrahtBot added the label Build system on May 23, 2025
Labels
Build system
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-25 18:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-25 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me