Replace dead gnome link notificator.cpp #32629
pull strmfos wants to merge 2 commits into bitcoin:master from strmfos:master changing 1 files +0 −1-
strmfos commented at 9:28 am on May 28, 2025: contributorHey team—noticed a dead link, replaced it with a working URL https://developer.gnome.org/notification-spec/ - old link https://developer.gnome.org/documentation/tutorials/notifications.html - new link
-
Replace dead gnome link notificator.cpp f9b0959e24
-
DrahtBot commented at 9:28 am on May 28, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32629.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
-
in src/qt/notificator.cpp:144 in f9b0959e24 outdated
140@@ -141,7 +141,7 @@ QVariant FreedesktopImage::toVariant(const QImage &img) 141 142 void Notificator::notifyDBus(Class cls, const QString &title, const QString &text, const QIcon &icon, int millisTimeout) 143 { 144- // https://developer.gnome.org/notification-spec/ 145+ // https://developer.gnome.org/documentation/tutorials/notifications.html
hebasto commented at 12:04 pm on May 28, 2025:I don’t see how the new link helps with understanding theNotificator::notifyDBus()
function code Perhaps it’s best to just remove the outdated comment?
strmfos commented at 7:16 pm on May 28, 2025:Agreed, the link doesn’t directly help understand the code Should I remove it?
hebasto commented at 12:33 pm on May 29, 2025:Agreed, the link doesn’t directly help understand the code Should I remove it?
I think so.
hebasto added the label GUI on May 28, 2025removed obsolete link 833880c1e0DrahtBot added the label CI failed on May 29, 2025fanquake commented at 2:18 pm on May 29, 2025: memberI’ll cherry pick this into a different branch.fanquake closed this on May 29, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-09 06:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-09 06:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me