test: update BIP340 test vectors and implementation (variable-length messages) #32642
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202505-test-update_bip340_test_vectors changing 2 files +5 −3-
theStack commented at 0:04 am on May 30, 2025: contributorThis PR updates the Schnorr signatures implementation in the functional test framework to the latest BIP changes (see https://github.com/bitcoin/bips/pull/1446,commit 200f9b26fe0a2f235a2af8b30c4be9f12f6bc9cb) and syncs the test vectors accordingly. Practically, we probably don’t need non-32-bytes message signing/verifying any time soon, but it seems good practice anyways to update.
-
test: update BIP340 test vectors and implementation (variable-length messages)
See https://github.com/bitcoin/bips/pull/1446, commit 200f9b26fe0a2f235a2af8b30c4be9f12f6bc9cb
-
DrahtBot commented at 0:04 am on May 30, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32642.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK real-or-random, jonasnick If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Tests on May 30, 2025
-
fanquake commented at 9:49 am on May 30, 2025: member
-
real-or-random approved
-
real-or-random commented at 12:02 pm on May 30, 2025: contributor
utACK b184f5c87c418ea49429e4ce0520c655d458306b
In the long run, it may make sense to depend on (and perhaps vendor) https://github.com/secp256k1lab/secp256k1lab for the EC parts of the test framework. It’s essentially an improved version of @sipa’s EC test framework code.
-
jonasnick commented at 3:00 pm on June 9, 2025: contributorutACK b184f5c87c418ea49429e4ce0520c655d458306b
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-15 06:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-15 06:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me