This PR updates the Schnorr signatures implementation in the functional test framework to the latest BIP changes (see https://github.com/bitcoin/bips/pull/1446,commit 200f9b26fe0a2f235a2af8b30c4be9f12f6bc9cb) and syncs the test vectors accordingly. Practically, we probably don't need non-32-bytes message signing/verifying any time soon, but it seems good practice anyways to update.
test: update BIP340 test vectors and implementation (variable-length messages) #32642
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202505-test-update_bip340_test_vectors changing 2 files +5 −3-
theStack commented at 12:04 AM on May 30, 2025: contributor
-
b184f5c87c
test: update BIP340 test vectors and implementation (variable-length messages)
See https://github.com/bitcoin/bips/pull/1446, commit 200f9b26fe0a2f235a2af8b30c4be9f12f6bc9cb
-
DrahtBot commented at 12:04 AM on May 30, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32642.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK real-or-random, jonasnick, stratospher, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label Tests on May 30, 2025
-
fanquake commented at 9:49 AM on May 30, 2025: member
- real-or-random approved
-
real-or-random commented at 12:02 PM on May 30, 2025: contributor
utACK b184f5c87c418ea49429e4ce0520c655d458306b
In the long run, it may make sense to depend on (and perhaps vendor) https://github.com/secp256k1lab/secp256k1lab for the EC parts of the test framework. It's essentially an improved version of @sipa's EC test framework code.
-
jonasnick commented at 3:00 PM on June 9, 2025: contributor
utACK b184f5c87c418ea49429e4ce0520c655d458306b
-
stratospher commented at 5:15 AM on June 20, 2025: contributor
ACK b184f5c.
-
achow101 commented at 9:27 PM on June 20, 2025: member
ACK b184f5c87c418ea49429e4ce0520c655d458306b
Test vectors match the bip changes
- achow101 merged this on Jun 20, 2025
- achow101 closed this on Jun 20, 2025
- theStack deleted the branch on Jun 21, 2025
- stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
- alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
- alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
- alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
- yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
- bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
- stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
- Kino1994 referenced this in commit 7204bc5485 on Jun 28, 2026
- BigcoinBGC referenced this in commit 7e970620f1 on Jun 30, 2026
- bitcoin locked this on Jul 30, 2026
