build: Find Boost in config mode #32667

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250602-boost-config changing 1 files +5 −24
  1. hebasto commented at 9:14 PM on June 2, 2025: member

    The FindBoost module has been removed by policy CMP0167.

  2. hebasto added the label Build system on Jun 2, 2025
  3. DrahtBot commented at 9:14 PM on June 2, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32667.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK purpleKarrot

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. in cmake/module/AddBoostIfNeeded.cmake:34 in 9cf00ebe4b outdated 
      16 | @@ -17,17 +17,8 @@ function(add_boost_if_needed)
  17 |    directory and other added INTERFACE properties.
  18 |    ]=]
  19 |  
  20 | -  # We cannot rely on find_package(Boost ...) to work properly without
  21 | -  # Boost_NO_BOOST_CMAKE set until we require a more recent Boost because
  22 | -  # upstream did not ship proper CMake files until 1.82.0.
    fanquake commented at 9:27 PM on June 2, 2025:

    We cannot rely on find_package(Boost ...) to work properly without Boost_NO_BOOST_CMAKE set until we require a more recent Boost because upstream did not ship proper CMake files until 1.82.0.

    We still support Boost 1.73+, and older verisons of CMake. Why is this ok to remove now?

    hebasto commented at 10:43 PM on June 2, 2025:

    IIRC, this comment was about "proper CMake files" shipped with source archives.

    For example, Ubuntu 22.04 ships Boost 1.74 with package configuration files:

    /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake
/usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfigVersion.cmake
/usr/lib/x86_64-linux-gnu/cmake/BoostDetectToolset-1.74.0.cmake
/usr/lib/x86_64-linux-gnu/cmake/boost_headers-1.74.0/boost_headers-config-version.cmake
/usr/lib/x86_64-linux-gnu/cmake/boost_headers-1.74.0/boost_headers-config.cmake
  5. fanquake commented at 7:13 AM on June 3, 2025: member

    https://github.com/bitcoin/bitcoin/actions/runs/15402950316/job/43339643754?pr=32667#step:8:1505:

    -- Looking for C++ include boost/test/included/unit_test.hpp
-- Looking for C++ include boost/test/included/unit_test.hpp - not found
CMake Error at cmake/module/AddBoostIfNeeded.cmake:65 (message):
  Building test_bitcoin executable requested but
  boost/test/included/unit_test.hpp header not available.
Call Stack (most recent call first):
  CMakeLists.txt:413 (add_boost_if_needed)


-- Configuring incomplete, errors occurred!
  6. hebasto force-pushed on Jun 3, 2025
  7. hebasto force-pushed on Jun 25, 2025
  8. fanquake commented at 1:21 PM on June 26, 2025: member

    #32665 has been merged.

  9. hebasto force-pushed on Jun 26, 2025
  10. hebasto marked this as ready for review on Jun 26, 2025
  11. fanquake commented at 1:23 PM on June 26, 2025: member

    cc @purpleKarrot

  12. hebasto commented at 1:23 PM on June 26, 2025: member

    #32665 has been merged.

    Thanks! Rebased.

  13. hebasto commented at 1:39 PM on June 26, 2025: member

    FWIW, I successfully built 639592548eeb4722c7655001d70a5f17bfda2a56 on Ubuntu 22.04 with the system-provided Boost 1.74.0.

  14. purpleKarrot commented at 1:40 PM on June 26, 2025: contributor

    ACK 639592548eeb4722c7655001d70a5f17bfda2a56

  15. fanquake referenced this in commit 67ea4b9994 on Jun 26, 2025
  16. fanquake commented at 2:01 PM on June 26, 2025: member

    Needs a rebase for #32814.

  17. DrahtBot added the label Needs rebase on Jun 26, 2025
  18. hebasto force-pushed on Jun 26, 2025
  19. hebasto commented at 3:47 PM on June 26, 2025: member

    Needs a rebase for #32814.

    Thanks! Rebased.

  20. build: Find Boost in config mode
    The `FindBoost` module has been removed by policy CMP0167.
    14653b869b
  21. hebasto force-pushed on Jun 26, 2025
  22. hebasto commented at 3:50 PM on June 26, 2025: member

    Added EXACT keyword to find_package(boost_included_unit_test_framework ...) command when using vcpkg (on Windows).

  23. DrahtBot removed the label Needs rebase on Jun 26, 2025
  24. fanquake commented at 12:48 PM on June 27, 2025: member

    @purpleKarrot want to take another look here?

  25. purpleKarrot commented at 12:52 PM on June 27, 2025: contributor

    ACK 14653b869b91f8013656099c9eb23b3518b8e53e

  26. fanquake commented at 1:49 PM on June 27, 2025: member

    Guix Build:

    f5e794c539bcf8260fe68be5893004f3a8f7aacbaba794704116b0fc38dd5813  guix-build-14653b869b91/output/aarch64-linux-gnu/SHA256SUMS.part
a701102c9ae49f32c780241a0dbfe16589213cbb43d7c48d8ca35de0c9032c2f  guix-build-14653b869b91/output/aarch64-linux-gnu/bitcoin-14653b869b91-aarch64-linux-gnu-debug.tar.gz
e0f184484a32b5a00c8034a3cb3985e21abf6df342602e6ad4cd3063ccd12f2f  guix-build-14653b869b91/output/aarch64-linux-gnu/bitcoin-14653b869b91-aarch64-linux-gnu.tar.gz
4ef01b549490fff7025047463ed15db43e274586b36f872efae0ccbfa2b12d2c  guix-build-14653b869b91/output/arm-linux-gnueabihf/SHA256SUMS.part
d90daed24f3f09e9a2a04dc7b5f307d2142a47d26d0138836109ce654869b724  guix-build-14653b869b91/output/arm-linux-gnueabihf/bitcoin-14653b869b91-arm-linux-gnueabihf-debug.tar.gz
687b14559afa008ea2742833e2fd70cd5674e09d2293c2236b51d16021212487  guix-build-14653b869b91/output/arm-linux-gnueabihf/bitcoin-14653b869b91-arm-linux-gnueabihf.tar.gz
5b4645bb93c812404876dd1dbcc430faedbae74dc03bcf8324542ce7cd458b7c  guix-build-14653b869b91/output/arm64-apple-darwin/SHA256SUMS.part
6ed6ef52b5069c89a7e4f7f34f8e55788a79777c6778ff08c58574b1268ddd2d  guix-build-14653b869b91/output/arm64-apple-darwin/bitcoin-14653b869b91-arm64-apple-darwin-codesigning.tar.gz
e71b1acbedeaea13d8c71f3c359c6aaaf21bb588e97e2c5c739dfa5bfbbbb397  guix-build-14653b869b91/output/arm64-apple-darwin/bitcoin-14653b869b91-arm64-apple-darwin-unsigned.tar.gz
7448fc2b8bf53bbc2f11595b3e41976e2677550dc3d670d412ddc5b46b3651e0  guix-build-14653b869b91/output/arm64-apple-darwin/bitcoin-14653b869b91-arm64-apple-darwin-unsigned.zip
de249d368f23f25f1be9e99352d20c1fbabfdc92ac39c21743935520b0ba3123  guix-build-14653b869b91/output/dist-archive/bitcoin-14653b869b91.tar.gz
cfbb3d9a51c4d86f573cbd4363146002fe7de9cbfa59f73c93abfa5212e9dbe5  guix-build-14653b869b91/output/powerpc64-linux-gnu/SHA256SUMS.part
6af8e92d59c188232512bd173b8e07ce4caac71f9576012555f5f41ffe242d3b  guix-build-14653b869b91/output/powerpc64-linux-gnu/bitcoin-14653b869b91-powerpc64-linux-gnu-debug.tar.gz
53917af857dd5bb8acd6ef79f7125edf83d53010d8360342f62a0f69e8f2930a  guix-build-14653b869b91/output/powerpc64-linux-gnu/bitcoin-14653b869b91-powerpc64-linux-gnu.tar.gz
52736ccd03732222992ddd693a308dc690bbca3c33b3b8504779b8b59c99fe8c  guix-build-14653b869b91/output/riscv64-linux-gnu/SHA256SUMS.part
a6d82ab0916bb87139d9a08f36cd28687dbfd0bb9f6d6b2b89b9ac9eb0c03072  guix-build-14653b869b91/output/riscv64-linux-gnu/bitcoin-14653b869b91-riscv64-linux-gnu-debug.tar.gz
2fa63d0694b670c871c0a95e811182538e46184dcaa35858509bf40f726ecbdc  guix-build-14653b869b91/output/riscv64-linux-gnu/bitcoin-14653b869b91-riscv64-linux-gnu.tar.gz
b6aece44a64862f5d0fafb372511d358db14b35b918484775febf27bb160e8cb  guix-build-14653b869b91/output/x86_64-apple-darwin/SHA256SUMS.part
47641645fddf599e89fd787580661d9cb7ee3acbad93b94bcd928c5974c73467  guix-build-14653b869b91/output/x86_64-apple-darwin/bitcoin-14653b869b91-x86_64-apple-darwin-codesigning.tar.gz
119b344ffc7f4d8edbfec0a3fcc28d73dece9d3803d91d68a3929d840433d403  guix-build-14653b869b91/output/x86_64-apple-darwin/bitcoin-14653b869b91-x86_64-apple-darwin-unsigned.tar.gz
116fde892e44d328ffe8b9534cd659211742ea51af4a81645700f58bad361d64  guix-build-14653b869b91/output/x86_64-apple-darwin/bitcoin-14653b869b91-x86_64-apple-darwin-unsigned.zip
b3ef90a436df16343dc3a6985ec9ad10e7458e07891d1b56bf0d68f0edca1890  guix-build-14653b869b91/output/x86_64-linux-gnu/SHA256SUMS.part
7dce046ef31de3780a4233e408c8ad57c7d64746c0d389617e5b30bc1de2df81  guix-build-14653b869b91/output/x86_64-linux-gnu/bitcoin-14653b869b91-x86_64-linux-gnu-debug.tar.gz
27c566afbbe75dd37417806aedfef2337925fa07a77fe580429f751b90705bf8  guix-build-14653b869b91/output/x86_64-linux-gnu/bitcoin-14653b869b91-x86_64-linux-gnu.tar.gz
a133c45483bc5a2ff986c6f130b5c652a13f4f259029e76fd8387c18cb7a2158  guix-build-14653b869b91/output/x86_64-w64-mingw32/SHA256SUMS.part
e0090c32bd622283f1ad7eab7dcef9b0423ec768cac9173647eeebe928c8fae2  guix-build-14653b869b91/output/x86_64-w64-mingw32/bitcoin-14653b869b91-win64-codesigning.tar.gz
2c289a13dceccdfdfb4a9d16cfba9bb46c6bf62134332431ec4288d01b3510a0  guix-build-14653b869b91/output/x86_64-w64-mingw32/bitcoin-14653b869b91-win64-debug.zip
86ddc18dce2aa572c3ab664b32efe353a80cb1dca6a0ace42a987bb6121e02c2  guix-build-14653b869b91/output/x86_64-w64-mingw32/bitcoin-14653b869b91-win64-setup-unsigned.exe
2fae9489aceaf36ac6d3851c561e8f5c5b5c56b9334b352825d913176ff773b7  guix-build-14653b869b91/output/x86_64-w64-mingw32/bitcoin-14653b869b91-win64-unsigned.zip
  27. fanquake merged this on Jun 27, 2025
  28. fanquake closed this on Jun 27, 2025
  29. hebasto deleted the branch on Jun 27, 2025
  30. hebasto referenced this in commit 0e965043a4 on Jun 29, 2025
  31. hebasto referenced this in commit 4eb3cee919 on Jun 29, 2025
  32. fanquake referenced this in commit bf75c9964f on Jul 2, 2025
  33. stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
  34. alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
  35. alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
  36. alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
  37. saikiran57 referenced this in commit a9e42f52be on Jul 28, 2025
  38. yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
  39. janus referenced this in commit fdc66d793b on Sep 14, 2025
  40. bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
  41. stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
  42. Kino1994 referenced this in commit 2ba5a5172f on Jun 28, 2026
  43. Kino1994 referenced this in commit 16d26b5ce3 on Jun 28, 2026
  44. Kino1994 referenced this in commit fcad07d9b3 on Jun 28, 2026
  45. Kino1994 referenced this in commit 91c0c39553 on Jun 28, 2026
  46. BigcoinBGC referenced this in commit c9be494d56 on Jun 30, 2026
  47. BigcoinBGC referenced this in commit 73ca545df9 on Jun 30, 2026
  48. BigcoinBGC referenced this in commit 1c510105bc on Jun 30, 2026
  49. BigcoinBGC referenced this in commit 9c4d6c1d7a on Jun 30, 2026
  50. bitcoin locked this on Jul 30, 2026
Contributors
hebastoDrahtBotfanquakepurpleKarrot
Labels
Build system
Linked (view graph)
#32595 build: add a depends dependency provider#32814 cmake: Explicitly specify `Boost_ROOT` for Homebrew's package#32828 build, docs: Fix Boost-related issues on NetBSD
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-21 06:51 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me