rpc, doc: update listdescriptors RCP help #32708

pull rkrux wants to merge 1 commits into bitcoin:master from rkrux:list-desc changing 1 files +1 −1
  1. rkrux commented at 9:47 am on June 9, 2025: contributor

    This RPC lists all the descriptors present in the wallet, not only the ones that were imported, but also the ones generated when a new wallet is created.

    It can be verified by creating a new wallet and calling the listdescriptors RPC, which will contain 8 ranged descriptors that are created for every new wallet.

    Also, update the description to get rid of “descriptor-enabled” because this is the only wallet type available now after removal of legacy wallets.

  2. rpc, doc: update `listdescriptors` RCP help
    This RPC lists all the descriptors present in the wallet, not only
    the ones that were imported, but also the ones generated when a
    new wallet is created.
    
    It can be verified by creating a new wallet and calling the
    `listdescriptors` RPC, which will contain 8 ranged descriptors that
    are created for every new wallet.
    
    Also, update the description to get rid of "descriptor-enabled"
    because this is the only wallet type available now after removal of
    legacy wallets.
    b44514b876
  3. DrahtBot commented at 9:47 am on June 9, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32708.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, pablomartin4btc, theStack, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. maflcko commented at 12:33 pm on June 9, 2025: member
    lgtm ACK b44514b876333a94ae242da8b1e4cee439c2d37e
  5. pablomartin4btc commented at 2:42 pm on June 9, 2025: member

    ACK b44514b876333a94ae242da8b1e4cee439c2d37e

    Since you are there I think there’s a dead code for “non-descriptor wallets” as those can’t be loaded anymore:

    https://github.com/bitcoin/bitcoin/blob/b44514b876333a94ae242da8b1e4cee439c2d37e/src/wallet/rpc/backup.cpp#L496-L498

  6. theStack approved
  7. theStack commented at 4:28 pm on June 9, 2025: contributor
    ACK b44514b876333a94ae242da8b1e4cee439c2d37e
  8. achow101 commented at 8:57 pm on June 9, 2025: member
    ACK b44514b876333a94ae242da8b1e4cee439c2d37e
  9. achow101 merged this on Jun 9, 2025
  10. achow101 closed this on Jun 9, 2025

  11. fanquake commented at 10:32 am on June 10, 2025: member
    Partial backport to 29.x in #32589.
  12. fanquake referenced this in commit 78688c8413 on Jun 10, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-15 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me