rpc, doc: update `listdescriptors` RCP help #32708

pull rkrux wants to merge 1 commits into bitcoin:master from rkrux:list-desc changing 1 files +1 −1
  1. rkrux commented at 9:47 AM on June 9, 2025: contributor

    This RPC lists all the descriptors present in the wallet, not only the ones that were imported, but also the ones generated when a new wallet is created.

    It can be verified by creating a new wallet and calling the listdescriptors RPC, which will contain 8 ranged descriptors that are created for every new wallet.

    Also, update the description to get rid of "descriptor-enabled" because this is the only wallet type available now after removal of legacy wallets.

  2. rpc, doc: update `listdescriptors` RCP help
    This RPC lists all the descriptors present in the wallet, not only
    the ones that were imported, but also the ones generated when a
    new wallet is created.
    
    It can be verified by creating a new wallet and calling the
    `listdescriptors` RPC, which will contain 8 ranged descriptors that
    are created for every new wallet.
    
    Also, update the description to get rid of "descriptor-enabled"
    because this is the only wallet type available now after removal of
    legacy wallets.
    b44514b876
  3. DrahtBot commented at 9:47 AM on June 9, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32708.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, pablomartin4btc, theStack, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. maflcko commented at 12:33 PM on June 9, 2025: member

    lgtm ACK b44514b876333a94ae242da8b1e4cee439c2d37e

  5. pablomartin4btc commented at 2:42 PM on June 9, 2025: member

    ACK b44514b876333a94ae242da8b1e4cee439c2d37e

    Since you are there I think there's a dead code for "non-descriptor wallets" as those can't be loaded anymore:

    https://github.com/bitcoin/bitcoin/blob/b44514b876333a94ae242da8b1e4cee439c2d37e/src/wallet/rpc/backup.cpp#L496-L498

  6. theStack approved
  7. theStack commented at 4:28 PM on June 9, 2025: contributor

    ACK b44514b876333a94ae242da8b1e4cee439c2d37e

  8. achow101 commented at 8:57 PM on June 9, 2025: member

    ACK b44514b876333a94ae242da8b1e4cee439c2d37e

  9. achow101 merged this on Jun 9, 2025
  10. achow101 closed this on Jun 9, 2025

  11. fanquake commented at 10:32 AM on June 10, 2025: member

    Partial backport to 29.x in #32589.

  12. fanquake referenced this in commit 78688c8413 on Jun 10, 2025
  13. sedited referenced this in commit f236a50dc1 on Jun 14, 2025
  14. fanquake referenced this in commit 983b268768 on Jun 25, 2025
  15. yuvicc referenced this in commit 069643f094 on Jul 6, 2025
  16. luke-jr referenced this in commit 5392066196 on Jul 17, 2025
  17. yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
  18. bug-castercv502 referenced this in commit cfdba67027 on Sep 28, 2025
  19. stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
  20. morozow referenced this in commit 9fedb1602a on May 8, 2026
  21. morozow referenced this in commit c81a1e776a on May 8, 2026
  22. Kino1994 referenced this in commit c985c65ec4 on Jun 28, 2026
  23. BigcoinBGC referenced this in commit 13bccd6367 on Jun 30, 2026
  24. bitcoin locked this on Jul 30, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-11 12:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me