tsan: remove note about dropping Qt wildcards #32739

1. 
   fanquake commented at 4:59 pm on June 12, 2025: member

   Doing so looks unmaintainable.
2. 
   DrahtBot commented at 4:59 pm on June 12, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32739.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. 
   maflcko commented at 7:47 pm on June 12, 2025: member

   I don’t think the CI has the GUI enabled?

   https://github.com/bitcoin/bitcoin/blob/5757de4ddd37f9321ee6b338b40888fd3561fc00/ci/test/00_setup_env_native_tsan.sh#L13-L16

   I guess you enabled it locally? Still, the gui unit tests reach not too much coverage, so just using them may not be enough.

   If this looks too unruly to maintain,

   Yeah, if we are just maintaining the non-wildcard list without any prospect of anyone fixing or reporting any of them, I don’t think this is worth it.

4. 
   fanquake commented at 5:55 am on June 13, 2025: member

   I don’t think the CI has the GUI enabled?

   It does: https://cirrus-ci.com/task/5347460467392512?logs=ci#L2040

   I don’t think this is worth it.

   Sure, will just drop the replacement comment.

5. 
   maflcko commented at 6:20 am on June 13, 2025: member

   I don’t think the CI has the GUI enabled?

   It does: https://cirrus-ci.com/task/5347460467392512?logs=ci#L2040

   I was confused. The default for BUILD_GUI is off; and git grep BUILD_GUI ./ci/test/00_setup_env_native_tsan.sh is empty. However, the gui is enabled via depends.

6. tsan: remove note about dropping Qt wildcards

   Doing so looks unmaintainable.

   5db0a4a2db
7. fanquake force-pushed on Jun 13, 2025
8. fanquake marked this as ready for review on Jun 13, 2025
9. fanquake renamed this:
   tsan: drop Qt wildcard suppressions
   tsan: remove note about dropping Qt wildcards
   on Jun 13, 2025
10. 
    fanquake commented at 10:52 am on June 13, 2025: member

    Swapped to just dropping the TODO.
11. 
    maflcko commented at 11:10 am on June 13, 2025: member

    lgtm ACK 5db0a4a2db205901965e38fb5e2107c61d5d5be6
12. fanquake merged this on Jun 13, 2025
13. fanquake closed this on Jun 13, 2025

    ---

14. fanquake deleted the branch on Jun 13, 2025

Contributors
fanquake DrahtBot maflcko