Doing so looks unmaintainable.
tsan: remove note about dropping Qt wildcards #32739
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:unwildcard_qt changing 1 files +1 −1-
fanquake commented at 4:59 PM on June 12, 2025: member
-
DrahtBot commented at 4:59 PM on June 12, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32739.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 7:47 PM on June 12, 2025: member
I don't think the CI has the GUI enabled?
I guess you enabled it locally? Still, the gui unit tests reach not too much coverage, so just using them may not be enough.
If this looks too unruly to maintain,
Yeah, if we are just maintaining the non-wildcard list without any prospect of anyone fixing or reporting any of them, I don't think this is worth it.
-
fanquake commented at 5:55 AM on June 13, 2025: member
I don't think the CI has the GUI enabled?
It does: https://cirrus-ci.com/task/5347460467392512?logs=ci#L2040
I don't think this is worth it.
Sure, will just drop the replacement comment.
-
maflcko commented at 6:20 AM on June 13, 2025: member
I don't think the CI has the GUI enabled?
It does: https://cirrus-ci.com/task/5347460467392512?logs=ci#L2040
I was confused. The default for
BUILD_GUIis off; andgit grep BUILD_GUI ./ci/test/00_setup_env_native_tsan.shis empty. However, the gui is enabled via depends. -
5db0a4a2db
tsan: remove note about dropping Qt wildcards
Doing so looks unmaintainable.
- fanquake force-pushed on Jun 13, 2025
- fanquake marked this as ready for review on Jun 13, 2025
- fanquake renamed this:
tsan: drop Qt wildcard suppressions
tsan: remove note about dropping Qt wildcards
on Jun 13, 2025 -
fanquake commented at 10:52 AM on June 13, 2025: member
Swapped to just dropping the TODO.
-
maflcko commented at 11:10 AM on June 13, 2025: member
lgtm ACK 5db0a4a2db205901965e38fb5e2107c61d5d5be6
- fanquake merged this on Jun 13, 2025
- fanquake closed this on Jun 13, 2025
- fanquake deleted the branch on Jun 13, 2025
