Fixes #32334
The test feature_bip68_sequence.py fails with IndexError: list index out of range error due to a mismatch between the number of inputs requested (at random) and the number of UTXOs available. The error is reproducible with the randomseed:
$ ./build/test/functional/feature_bip68_sequence.py --randomseed 6169832640268785903
This PR adds a valid upper bound to randomly select the inputs.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32765.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | maflcko, Prabhat1308, theStack |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Approach ACK
The tests passes even with the original suggestion from the issue here , I wonder why you did not go with that ?
Although I see no issues with the current approach
UPD: The test did run noticably slower with the original suggestion
143 | @@ -144,8 +144,10 @@ def test_sequence_lock_confirmed_inputs(self): 144 | # between height/time locking). Small random chance of making the locks 145 | # all pass. 146 | for _ in range(400): 147 | + available_utxos = len(utxos) 148 | + 149 | # Randomly choose up to 10 inputs
~This comment should be changed along the line "randomly choose upto minimum of 10 and available_utxo inputs here " now since its also bounded by the size of available_utxos~
Technically the statement still stands so no need to change
Yes, still the maximum bound is 10.
lgtm ACK e285e691b7a311e278f89e9fe423716de1ee268b
re-ACK e285e69
ACK e285e691b7a311e278f89e9fe423716de1ee268b
Thanks for fixing!
