cmake: Explicitly specify Boost_ROOT for Homebrew’s package #32814

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250624-findboost changing 1 files +12 −0
  1. hebasto commented at 5:53 pm on June 25, 2025: member

    On macOS, this PR ensures that the Boost package is located at its real path rather than via the symlink in the default prefix.

    A backport to 29.x is required for #32804, as this change prevents contamination of include directories by broad locations such as /usr/local/include or /opt/homebrew/include, which take precedence over Qt’s -iframework flags.

    Below is the relevant change in the configuration logs on my macOS 15.5 x64:

    • master branch @ ead44687483e9c936ba970de890c01d5e7ad3485:
    0% cmake -B build
    1<snip>
    2-- Found Boost: /usr/local/include (found suitable version "1.88.0", minimum required is "1.73.0")
    3<snip>
    
    • this PR:
    0% cmake -B build
    1<snip>
    2-- Found Boost: /usr/local/opt/boost/include (found suitable version "1.88.0", minimum required is "1.73.0")
    3<snip>
    

    This PR is forward-compatible with the changes proposed in #32667.

  2. cmake: Explicitly specify `Boost_ROOT` for Homebrew's package
    On macOS, this change ensures that the Boost package is located at its
    real path rather than via the symlink in the default prefix.
    8800b5acc1
  3. hebasto added the label macOS on Jun 25, 2025
  4. hebasto added the label Build system on Jun 25, 2025
  5. hebasto added the label Needs backport (29.x) on Jun 25, 2025
  6. DrahtBot commented at 5:53 pm on June 25, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32814.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake
    Concept ACK purpleKarrot

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32667 (build: Find Boost in config mode by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. hebasto added this to the milestone 29.1 on Jun 26, 2025
  8. fanquake commented at 1:10 pm on June 26, 2025: member
  9. purpleKarrot commented at 1:17 pm on June 26, 2025: contributor
    ACK
  10. fanquake approved
  11. fanquake commented at 1:59 pm on June 26, 2025: member
    ACK 8800b5acc1ef7abe6c5260ae0be5386b1d593a19 Checked that this plus #32805 fixes #31009
  12. fanquake merged this on Jun 26, 2025
  13. fanquake closed this on Jun 26, 2025

  14. fanquake referenced this in commit a3c1939d6e on Jun 26, 2025
  15. fanquake removed the label Needs backport (29.x) on Jun 26, 2025
  16. fanquake commented at 2:03 pm on June 26, 2025: member
    Backported to 29.x in #32810.
  17. hebasto deleted the branch on Jun 26, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-28 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me