build, docs: Fix Boost-related issues on NetBSD #32828

1. 
   hebasto commented at 7:05 pm on June 29, 2025: member

   The recently merged #32667 broke builds on NetBSD due to the following issues:

   1. The boost-headers package does not provide CMake configuration files now required since #32667.

      The first commit updates the Build Guide to recommend using the boost package instead.

   2. The CMake configuration file provided by the boost package is broken.

      The second commit adds a workaround for this issue.

   Upstream issues:

   • https://github.com/NetBSD/pkgsrc/issues/167
   • https://github.com/NetBSD/pkgsrc/issues/168

   Successful CI job: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/15958818914/job/45008576879.

2. doc: Update NetBSD Build Guide

   The `boost-headers` package does not provide CMake configuration files
   required since https://github.com/bitcoin/bitcoin/pull/32667. Install
   the `boost` package instead.

   4eb3cee919
3. hebasto added the label Docs on Jun 29, 2025
4. 
   DrahtBot commented at 7:05 pm on June 29, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32828.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	purpleKarrot

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. hebasto marked this as a draft on Jun 29, 2025
6. hebasto added the label Build system on Jun 29, 2025
7. hebasto renamed this:
   doc: Update NetBSD Build Guide
   build, docs: Fix Boost-related issues on NetBSD
   on Jun 29, 2025
8. hebasto marked this as ready for review on Jun 29, 2025
9. 
   fanquake commented at 10:03 am on June 30, 2025: member

   The boost-headers package does not provide CMake configuration files

   Is there an upstream issue for this?

10. in cmake/module/AddBoostIfNeeded.cmake:34 in 35a410740e outdated

    30@@ -31,6 +31,14 @@ function(add_boost_if_needed)
    31 
    32   find_package(Boost 1.73.0 REQUIRED CONFIG)
    33   mark_as_advanced(Boost_INCLUDE_DIR boost_headers_DIR)
    34+  # Workaround for a bug on NetBSD.
    

    ---

    ---

    

    fanquake commented at 10:27 am on June 30, 2025:

    This should link to the relevant issue.

    ---

    

    hebasto commented at 10:35 am on June 30, 2025:

    Sure! Added.
11. build: Add workaround for NetBSD bug in `Boost::headers` target

    Due to a bug in `boost_headers-config.cmake`, the `Boost::headers`
    target's `INTERFACE_INCLUDE_DIRECTORIES` property is set to "/usr",
    which is incorrect.

    5a5ddbd789
12. hebasto force-pushed on Jun 30, 2025
13. 
    hebasto commented at 11:04 am on June 30, 2025: member

    The boost-headers package does not provide CMake configuration files

    Is there an upstream issue for this?

    https://github.com/NetBSD/pkgsrc/issues/168.

14. 
    fanquake commented at 9:00 am on July 1, 2025: member

    cc @purpleKarrot
15. 
    purpleKarrot commented at 9:11 am on July 1, 2025: contributor

    ACK 5a5ddbd78922236402df378c8588a7b0b3f83a13

    I wonder why no other projects run into this issue.

16. maflcko removed the label Docs on Jul 1, 2025
17. 
    fanquake commented at 12:24 pm on July 2, 2025: member

    I wonder why no other projects run into this issue.

    Yea. I guess nobody else is using Boost, via CMake, on NetBSD?

18. fanquake merged this on Jul 2, 2025
19. fanquake closed this on Jul 2, 2025

    ---

20. hebasto deleted the branch on Jul 2, 2025

Contributors
hebasto DrahtBot fanquake purpleKarrot

Labels
Build system