test: Use msg_generic in p2p_ping.py #32834

1. 
   maflcko commented at 12:54 pm on June 30, 2025: member

   It seems odd to derive msg_pong_corrupt from msg_pong, but then overwrite the serialize method, when one can just directly use msg_generic to pass the raw bytes to send over the wire.

   Fix that by using msg_generic. This also serves as a regression test against the fix in commit 33480573cbd8d03aefbde100e51f827a2f7de7f7.

   (Can be tested by reverting that commit to observe a failure)

2. test: Use msg_generic in p2p_ping.py fa3f100010
3. DrahtBot added the label Tests on Jun 30, 2025
4. 
   DrahtBot commented at 12:54 pm on June 30, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32834.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge, theStack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. fanquake requested review from theStack on Jun 30, 2025
6. dergoegge approved
7. 
   dergoegge commented at 1:05 pm on June 30, 2025: member

   utACK fa3f100010f1a0273891ed0d14ddb3c5ccacbd4b
8. theStack approved
9. 
   theStack commented at 1:20 pm on June 30, 2025: contributor

   ACK fa3f100010f1a0273891ed0d14ddb3c5ccacbd4b

   Checked that this catches the issue fixed in #32833 as expected (i.e. p2p_ping.py fails if the msgtype slot is removed again from msg_generic).

10. fanquake merged this on Jun 30, 2025
11. fanquake closed this on Jun 30, 2025

    ---

12. maflcko deleted the branch on Jun 30, 2025

Contributors
maflcko DrahtBot dergoegge theStack

Labels
Tests