maflcko
commented at 12:54 PM on June 30, 2025:
member
It seems odd to derive msg_pong_corrupt from msg_pong, but then overwrite the serialize method, when one can just directly use msg_generic to pass the raw bytes to send over the wire.
Fix that by using msg_generic. This also serves as a regression test against the fix in commit 33480573cbd8d03aefbde100e51f827a2f7de7f7.
(Can be tested by reverting that commit to observe a failure)
test: Use msg_generic in p2p_ping.pyfa3f100010
DrahtBot added the label Tests on Jun 30, 2025
DrahtBot
commented at 12:54 PM on June 30, 2025:
contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-08-04 00:51 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me