feature_taproot: sample tx version border values more #32841

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2025-06-std_tx_taproot changing 1 files +5 −3

instagibbs commented at 9:03 PM on June 30, 2025: member

Currently if the version 3 is selected for an otherwise standard spender, the test will fail. It's unlikely but possible, so change the test to update expectations and sample more aggressively on border values to instigate failures much quicker in the future if another version is made standard.

feature_taproot: sample tx version border values more

Currently if the version 3 is selected for an otherwise
standard spender, the test will fail. It's unlikely but
possible, so change the test to update expectations and
sample more aggressively on border values to instigate
failures much quicker in the future if another version is
made standard.

4be81e9746

DrahtBot commented at 9:03 PM on June 30, 2025: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32841.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK darosior, maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
darosior approved
darosior commented at 9:29 AM on July 2, 2025: member

ACK 4be81e9746e9e18923386d6f4945a33885fd98a7
maflcko commented at 10:08 AM on July 2, 2025: member

lgtm ACK 4be81e9746e9e18923386d6f4945a33885fd98a7

Also tested the failure on current master.
fanquake merged this on Jul 2, 2025
fanquake closed this on Jul 2, 2025

Type	Reviewers
ACK	darosior, maflcko

in test/functional/feature_taproot.py:1541 in 4be81e9746

1537 | @@ -1535,8 +1538,7 @@ def test_spenders(self, node, spenders, input_counts):
1538 |                  is_standard_tx = (
1539 |                      fail_input is None  # Must be valid to be standard
1540 |                      and (all(utxo.spender.is_standard for utxo in input_utxos))  # All inputs must be standard
1541 | -                    and tx.version >= 1  # The tx version must be standard
1542 | -                    and tx.version <= 2)
1543 | +                    and tx.version in TX_STANDARD_VERSIONS)  # The tx version must be standard

maflcko commented at 2:39 PM on July 2, 2025:

i guess it is not enough and the truc rules need to be checked as well. Otherwise:

[10:00:08.436] �[0;36m                                   test_framework.authproxy.JSONRPCException: TRUC-violation, version=3 tx 18cf284e19b7df3927bb95ea6a15d7d710a180bb62ccf18ad05948915c85171f (wtxid=3a4704c5da033ee18e46813915c5bad5747277e40f9684689bb66ed91ac85256) is too big: 25250 > 10000 virtual bytes (-26)�[0m

https://cirrus-ci.com/task/6341200170450944?logs=ci#L2708

instagibbs commented at 2:43 PM on July 2, 2025:

There are no in-mempool deps afaik, so checking the vsize of tx should suffice?

instagibbs commented at 3:09 PM on July 2, 2025:

opened potential resolution at #32859

was able to reproduce the issue and not run into it anymore

achow101 referenced this in commit 1927432354 on Jul 2, 2025
fanquake referenced this in commit 9f3690b978 on Jul 3, 2025
fanquake commented at 11:17 AM on July 3, 2025: member

Backported to 29.x in #32863.
glozow referenced this in commit ef380a454c on Jul 18, 2025
stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
ajtowns referenced this in commit 40c8f51494 on Sep 4, 2025
bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
morozow referenced this in commit 57596a9d11 on May 8, 2026
morozow referenced this in commit 8214c3bc7c on May 8, 2026
Kino1994 referenced this in commit fbdc09a48b on Jun 28, 2026
Kino1994 referenced this in commit 1c4cda4406 on Jun 28, 2026
BigcoinBGC referenced this in commit 99595d3e4b on Jun 30, 2026
BigcoinBGC referenced this in commit 3c5026f4c4 on Jun 30, 2026
bitcoin locked this on Jul 30, 2026

Contributors

Linked (view graph)

#32859 functional test: correctly detect nonstd TRUC tx vsize in feature_taproot #32863 [29.x] Backports

feature_taproot: sample tx version border values more #32841

Code Coverage & Benchmarks

Reviews